[rv_dm] WARL behavior and NDM tracking fixes #22038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msfschaffner
changed the title
a-will
reviewed
Mar 14, 2024
msfschaffner
force-pushed
the
rv-dm-fixes
branch
3 times, most recently
from
79fe316 to
6da3819
Compare
msfschaffner
force-pushed
the
rv-dm-fixes
branch
from
6da3819 to
bcbbbdb
Compare
10 tasks
a-will
approved these changes
Mar 15, 2024
msfschaffner
force-pushed
the
rv-dm-fixes
branch
from
bcbbbdb to
384bc91
Compare
msfschaffner
requested review from
HU90m and
pamaury
and removed request for
a team and
HU90m
|
If anyone with an FPGA setup could help me debug the |
|
@msfschaffner: About the testing side of things: I've filed an issue (#22048) to track the work that needs doing. Assigning it to a PROD milestone is clearly the next job! I assume M4, but will leave that to someone with more knowledge of the roadmap/timescale. |
Thanks! PROD.M4 sounds right! |
Update code from upstream repository https://github.com/pulp- platform/riscv-dbg to revision 358f90110220adf7a083f8b65d157e836d706236 This also connects the nextdm input and ndmreset ack inputs in rv_dm, and ties them off. Implementation of ndmreset ack comes in a subsequent commit. Fixes lowRISC#19750 Signed-off-by: Michael Schaffner <msf@opentitan.org>
This adds tracking logic for NDM reset requests and issues an acknowledgement to the DM_CSRs so that dmstatus.allhavereset / dmstatus.anyhavereset can be asserted at the correct time. Fixes lowRISC#15123 Signed-off-by: Michael Schaffner <msf@opentitan.org>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #19750 and #15123.
TODO: we should file issues for BLT/TLT extensions.
@rswarbrick can you take care of the BLT part?
I filed an issue for TLTs here: #22044