Exam mode: Warn user before reloading the page
#10193
Conversation
github-actions
bot
added
the
client
WalkthroughThe pull request introduces a new functionality to the Changes
Assessment against linked issues
Possibly related PRs
Suggested Labels
Suggested Reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (1)
🧰 Additional context used📓 Path-based instructions (1)src/main/webapp/i18n/de/exam.json (1)Pattern ⏰ Context from checks skipped due to timeout of 90000ms (5)
🔇 Additional comments (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/webapp/app/exam/participate/exam-participation.component.ts(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
src/main/webapp/app/exam/participate/exam-participation.component.ts (1)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: client-tests
- GitHub Check: server-tests
- GitHub Check: Build and Push Docker Image
- GitHub Check: Analyse
🔇 Additional comments (1)
src/main/webapp/app/exam/participate/exam-participation.component.ts (1)
1-1: LGTM!The
HostListenerimport is correctly added to the existing@angular/coreimports.
| //Make sure to warn the user before leaving the page in exam mode | ||
| @HostListener('window:beforeunload', ['$event']) | ||
| beforeUnloadHandler(event: BeforeUnloadEvent) { | ||
| event.preventDefault(); | ||
| } | ||
|
|
There was a problem hiding this comment.
🛠️ Refactor suggestion
Enhance the reload warning implementation.
The current implementation prevents the default behavior but doesn't show a confirmation dialog. To properly warn users before reloading:
- Return a string message to show the browser's default confirmation dialog.
- Add a guard to only show the warning during active exams.
Apply this diff to improve the implementation:
//Make sure to warn the user before leaving the page in exam mode
@HostListener('window:beforeunload', ['$event'])
beforeUnloadHandler(event: BeforeUnloadEvent) {
+ // Only show warning if exam is active and not over
+ if (this.examStartConfirmed && !this.isOver()) {
event.preventDefault();
+ // Return a string to show browser's default confirmation dialog
+ return this.translateService.instant('artemisApp.examParticipation.reloadWarning');
+ }
+ return true;
}Committable suggestion skipped: line range outside the PR's diff.
…tom message when reloading
Checklist
General
Client
authoritiesto all new routes and checked the course groups for displaying navigation elements (links, buttons).Motivation and Context
Fixes #10142
Exam Mode Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Performance Review
Code Review
Manual Tests
Exam Mode Test
Performance Tests
Test Coverage
Screenshots
Summary by CodeRabbit