Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tickets/sitcom 1775 #25

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Tickets/sitcom 1775 #25

wants to merge 11 commits into from
+767 −0

Conversation

dsanmartim
Copy link

No description provided.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@craiglagegit
Copy link
Contributor

This looks like a very nice addition. I have wanted something like this many times. I had two issues.
(1) When I ran the notebook in the USDF RSP, when I got to the final step of selecting a salindex, it didn't display the logs like it does in TimeSquare. See the screen shot.
(2) In TimeSquare, when I changed the salindex and asked it to recompute, it didn't change. I suspect this is a TimeSquare issue and not and issue with the notebook.
Screenshot 2025-01-20 at 11 01 00 AM

craiglagegit
craiglagegit approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@craiglagegit craiglagegit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve. See comment in comments section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craiglagegit craiglagegit craiglagegit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsanmartim @craiglagegit