Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lucide-react, lucide-preact, lucide-react-native, lucide-solid, lucide-vue-next): Adjustable icon naming imports #2328

Merged
merged 17 commits into from
Nov 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ outlined
packages/**/src/icons/*.js
packages/**/src/icons/*.ts
packages/**/src/icons/*.tsx
packages/**/src/aliases/*.ts
packages/**/src/aliases.ts
!packages/**/src/aliases/index.ts
packages/**/src/dynamicIconImports.ts
packages/**/dynamicIconImports.js
packages/**/dynamicIconImports.d.ts
Expand Down
4 changes: 4 additions & 0 deletions docs/.vitepress/sidebar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ const sidebar: UserConfig<DefaultTheme.Config>['themeConfig']['sidebar'] = {
text: 'Filled icons',
link: '/guide/advanced/filled-icons',
},
{
text: 'Aliased Names',
link: '/guide/advanced/aliased-names',
},
// {
// text: 'Combining icons',
// },
Expand Down
93 changes: 93 additions & 0 deletions docs/guide/advanced/aliased-names.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,93 @@
# Aliased Names

Icons can have multiple names for the same icon. This is because we choose to rename some icons to make them more consistent with the rest of the icon set, or the name was not generic. For example, the `edit-2` icon is renamed to `pen` to make the name more generic, since it is just a pen icon.

Beside aliases names lucide also includes prefixed and suffixed names to use within your project. This is to prevent import name collisions with other libraries or your own code.

```tsx
// These are all the same icon
import {
Home,
HomeIcon,
LucideHome,
} from "lucide-react";
```

## Choosing import name style

To be consistent in your imports or want to change the autocompletion of Lucide icons in your IDE there an option to able the choose the import name style you want.

This can be done by creating a custom module declaration file to override the lucide imports and turning off the autocomplete in your IDE.

### Turn off autocomplete in your IDE

```json [.vscode/settings.json]
{
"typescript.preferences.autoImportFileExcludePatterns": [
"lucide-react", // or
"lucide-preact", // or
"lucide-react-native", // or
"lucide-vue-next",
]
}
```

### Create a custom module declaration file

Only available for `lucide-react`, `lucide-preact`, `lucide-react-native`, `lucide-vue-next` package.
This will enable you to choose the import name style you want to use in your project.

::: code-group

```ts [React]
declare module "lucide-react" {
// Prefixed import names
export * from "lucide-react/dist/lucide-react.prefixed";
// or
// Suffixed import names
export * from "lucide-react/dist/lucide-react.suffixed";
}
```

```ts [Vue]
declare module "lucide-vue-next" {
// Prefixed import names
export * from "lucide-vue-next/dist/lucide-vue-next.prefixed";
// or
// Suffixed import names
export * from "lucide-vue-next/dist/lucide-vue-next.suffixed";
}
```

```ts [Preact]
declare module "lucide-preact" {
// Prefixed import names
export * from "lucide-preact/dist/lucide-preact.prefixed";
// or
// Suffixed import names
export * from "lucide-preact/dist/lucide-preact.suffixed";
}
```

```ts [React Native]
declare module "lucide-react-native" {
// Prefixed import names
export * from "lucide-react-native/dist/lucide-react-native.prefixed";
// or
// Suffixed import names
export * from "lucide-react-native/dist/lucide-react-native.suffixed";
}
```

:::

Place this in your project root or in a folder where your tsconfig.json is located, or locate it in your defined type directory.
Easiest way is to create a `@types` folder in your project root and name the file `[package-name].d.ts`.

### Import name styles

| Import Style | Available imports | Declaration file import |
| ------------- | --------------------------- | ----------------------- |
| Default | Home, HomeIcon, LucideHome | |
| Prefixed | LucideHome | [package].prefixed |
| Suffixed | HomeIcon | [package].suffixed |
3 changes: 3 additions & 0 deletions icons/grid-2x2-plus.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"danielbayley",
"chessurisme",
"jguddas"
],
"tags": [

Check notice on line 8 in icons/grid-2x2-plus.json

View workflow job for this annotation

GitHub Actions / lint-contributors

Contributors have changed!

Don't add people who have only performed automatic optimizations. + "aliases": [ + "grid-2-x-2-plus" + ], @@ -32,3 +34,0 @@ - ], - "aliases": [ - "grid-2-x-2-plus"
"table",
"rows",
"columns",
Expand All @@ -29,5 +29,8 @@
"design",
"shapes",
"maths"
],
"aliases": [
"grid-2-x-2-plus"
]
}
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
"postinstall": "husky install",
"lint:es": "eslint .",
"lint:format": "prettier \"**/*.{js,mjs,ts,jsx,tsx,html,css,scss,json,yml,yaml}\" --check",
"lint:format-fix": "prettier \"**/*.{js,mjs,ts,jsx,tsx,html,css,scss,json,yml,yaml}\" --write",
"lint:json:icons": "ajv --spec=draft2020 -s icon.schema.json -d 'icons/*.json' > /dev/null",
"lint:json:categories": "ajv --spec=draft2020 -s category.schema.json -d 'categories/*.json' > /dev/null",
"lint:json": "pnpm run lint:json:icons && pnpm run lint:json:categories",
Expand Down
2 changes: 1 addition & 1 deletion packages/lucide-angular/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"build": "pnpm clean && pnpm copy:license && pnpm build:icons && pnpm build:ng",
"copy:license": "cp ../../LICENSE ./LICENSE",
"clean": "rm -rf dist && rm -rf ./src/icons/*.ts",
"build:icons": "build-icons --output=./src --templateSrc=./scripts/exportTemplate.mjs --renderUniqueKey --withAliases --aliasesFileExtension=.ts --iconFileExtension=.ts --exportFileName=lucide-icons.ts",
"build:icons": "build-icons --output=./src --templateSrc=./scripts/exportTemplate.mjs --renderUniqueKey --withAliases --aliasNamesOnly --aliasesFileExtension=.ts --iconFileExtension=.ts --exportFileName=lucide-icons.ts",
"build:ng": "ng build --configuration production",
"test": "ng test --no-watch --no-progress --browsers=ChromeHeadlessCI",
"test:watch": "ng test",
Expand Down
1 change: 1 addition & 0 deletions packages/lucide-angular/src/aliases/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from './aliases';
20 changes: 20 additions & 0 deletions packages/lucide-preact/rollup.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -69,5 +69,25 @@ export default [
],
plugins: [dts()],
},
{
input: `src/${outputFileName}.suffixed.ts`,
output: [
{
file: `dist/${outputFileName}.suffixed.d.ts`,
format: 'es',
},
],
plugins: [dts()],
},
{
input: `src/${outputFileName}.prefixed.ts`,
output: [
{
file: `dist/${outputFileName}.prefixed.d.ts`,
format: 'es',
},
],
plugins: [dts()],
},
...configs,
];
3 changes: 3 additions & 0 deletions packages/lucide-preact/src/aliases/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export * from './aliases';
export * from './prefixed';
export * from './suffixed';
7 changes: 7 additions & 0 deletions packages/lucide-preact/src/lucide-preact.prefixed.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
export * from './icons';
export * as icons from './icons';
export * from './aliases/prefixed';
export * from './types';

export { default as createLucideIcon } from './createLucideIcon';
export { default as Icon } from './Icon';
7 changes: 7 additions & 0 deletions packages/lucide-preact/src/lucide-preact.suffixed.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
export * from './icons';
export * as icons from './icons';
export * from './aliases/suffixed';
export * from './types';

export { default as createLucideIcon } from './createLucideIcon';
export { default as Icon } from './Icon';
20 changes: 20 additions & 0 deletions packages/lucide-react-native/rollup.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -60,5 +60,25 @@ export default [
],
plugins: [dts()],
},
{
input: `src/${outputFileName}.suffixed.ts`,
output: [
{
file: `dist/${outputFileName}.suffixed.d.ts`,
format: 'es',
},
],
plugins: [dts()],
},
{
input: `src/${outputFileName}.prefixed.ts`,
output: [
{
file: `dist/${outputFileName}.prefixed.d.ts`,
format: 'es',
},
],
plugins: [dts()],
},
...configs,
];
3 changes: 3 additions & 0 deletions packages/lucide-react-native/src/aliases/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export * from './aliases';
export * from './prefixed';
export * from './suffixed';
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
export * from './icons';
export * as icons from './icons';
export * from './aliases/prefixed';
export * from './types';

export { default as createLucideIcon } from './createLucideIcon';
export { default as Icon } from './Icon';
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
export * from './icons';
export * as icons from './icons';
export * from './aliases/suffixed';
export * from './types';

export { default as createLucideIcon } from './createLucideIcon';
export { default as Icon } from './Icon';
20 changes: 20 additions & 0 deletions packages/lucide-react/rollup.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -111,5 +111,25 @@ export default [
],
plugins: [dts()],
},
{
input: `src/${outputFileName}.suffixed.ts`,
output: [
{
file: `dist/${outputFileName}.suffixed.d.ts`,
format: 'es',
},
],
plugins: [dts()],
},
{
input: `src/${outputFileName}.prefixed.ts`,
output: [
{
file: `dist/${outputFileName}.prefixed.d.ts`,
format: 'es',
},
],
plugins: [dts()],
},
...configs,
];
3 changes: 3 additions & 0 deletions packages/lucide-react/src/aliases/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export * from './aliases';
export * from './prefixed';
export * from './suffixed';
6 changes: 6 additions & 0 deletions packages/lucide-react/src/lucide-react.prefixed.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
export * as icons from './icons';
export * from './aliases/prefixed';
export * from './types';

export { default as createLucideIcon } from './createLucideIcon';
export { default as Icon } from './Icon';
6 changes: 6 additions & 0 deletions packages/lucide-react/src/lucide-react.suffixed.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
export * as icons from './icons';
export * from './aliases/suffixed';
export * from './types';

export { default as createLucideIcon } from './createLucideIcon';
export { default as Icon } from './Icon';
3 changes: 3 additions & 0 deletions packages/lucide-solid/src/aliases/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export * from './aliases';
export * from './prefixed';
export * from './suffixed';
1 change: 1 addition & 0 deletions packages/lucide-static/src/aliases/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from './aliases';
3 changes: 3 additions & 0 deletions packages/lucide-svelte/src/aliases/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export * from './aliases';
export * from './prefixed';
export * from './suffixed';
10 changes: 5 additions & 5 deletions packages/lucide-svelte/src/lucide-svelte.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
export * from './icons/index.js';
export * as icons from './icons/index.js';
export * from './aliases.js';
export { default as defaultAttributes } from './defaultAttributes.js';
export * from './types.js';
export * from './icons/index';
export * as icons from './icons/index';
export * from './aliases';
export { default as defaultAttributes } from './defaultAttributes';
export * from './types';
export { default as Icon } from './Icon.svelte';
32 changes: 32 additions & 0 deletions packages/lucide-vue-next/rollup.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -75,5 +75,37 @@ export default [
}),
],
},
{
input: `src/${outputFileName}.suffixed.ts`,
output: [
{
file: `dist/${outputFileName}.suffixed.d.ts`,
format: 'es',
},
],
plugins: [
dts({
compilerOptions: {
preserveSymlinks: false,
},
}),
],
},
{
input: `src/${outputFileName}.prefixed.ts`,
output: [
{
file: `dist/${outputFileName}.prefixed.d.ts`,
format: 'es',
},
],
plugins: [
dts({
compilerOptions: {
preserveSymlinks: false,
},
}),
],
},
...configs,
];
2 changes: 1 addition & 1 deletion packages/lucide-vue-next/src/Icon.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { type FunctionalComponent, h } from 'vue';
import { mergeClasses, toKebabCase } from '@lucide/shared';
import { toKebabCase } from '@lucide/shared';
import defaultAttributes from './defaultAttributes';
import { IconNode, LucideProps } from './types';

Expand Down
3 changes: 3 additions & 0 deletions packages/lucide-vue-next/src/aliases/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export * from './aliases';
export * from './prefixed';
export * from './suffixed';
6 changes: 6 additions & 0 deletions packages/lucide-vue-next/src/lucide-vue-next.prefixed.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
export * as icons from './icons';
export * from './aliases/prefixed';
export * from './types';

export { default as createLucideIcon } from './createLucideIcon';
export { default as Icon } from './Icon';
6 changes: 6 additions & 0 deletions packages/lucide-vue-next/src/lucide-vue-next.suffixed.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
export * as icons from './icons';
export * from './aliases/suffixed';
export * from './types';

export { default as createLucideIcon } from './createLucideIcon';
export { default as Icon } from './Icon';
1 change: 1 addition & 0 deletions packages/lucide-vue/src/aliases/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from './aliases';
1 change: 1 addition & 0 deletions packages/lucide/src/aliases/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from './aliases';
Loading
Loading