Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix broken editorconfig-checker by pinning EC_VERSION in lint.yml workflow #58

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

lumirlumir
Copy link
Owner

This pull request includes an update to the .github/workflows/lint.yml file to enhance the security and stability of the linting process by pinning the editorconfig-checker version.

  • .github/workflows/lint.yml: Added an environment variable EC_VERSION set to 3.0.3 for editorconfig-checker to ensure a specific version is used.

Ref: See, editorconfig-checker/editorconfig-checker#409

Copy link

github-actions bot commented Jan 8, 2025

Labels have been automatically applied based on the conventional commit types.🏷️

@github-actions github-actions bot added the fix label Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.92%. Comparing base (eeadfa2) to head (19464e7).
Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##             main      #58   +/-   ##
=======================================
  Coverage   90.92%   90.92%           
=======================================
  Files           5        5           
  Lines         617      617           
=======================================
  Hits          561      561           
  Misses         56       56           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeadfa2...19464e7. Read the comment docs.

@lumirlumir lumirlumir changed the title fix: fix broken editorconfig-checker by pinning EC_VERSION in lint workflow fix: fix broken editorconfig-checker by pinning EC_VERSION in lint.yml workflow Jan 8, 2025
@lumirlumir lumirlumir merged commit 4c92a0b into main Jan 8, 2025
3 checks passed
@lumirlumir lumirlumir deleted the fix-editorconfig-checker-broken branch January 8, 2025 11:10
lumirlumir added a commit that referenced this pull request Jan 10, 2025
…` in `lint.yml` workflow (#58)"

This reverts commit 4c92a0b.
lumirlumir added a commit that referenced this pull request Jan 10, 2025
…N` in `lint.yml` workflow (#58)" (#64)

This reverts commit 4c92a0b.

Bug was fixed in `editorconfig-checker` repository. So it is no longer
needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant