Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-config-bananass): enforce JSX usage in no-unused-expressions rule #68

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

lumirlumir
Copy link
Owner

This pull request includes updates to the ESLint configuration in the packages/eslint-config-bananass directory. The most important changes involve modifying the rule for unused expressions and a minor documentation update in the test file.

ESLint rule modification:

Documentation update:

@github-actions github-actions bot added the fix label Jan 12, 2025
Copy link

Labels have been automatically applied based on the conventional commit types.🏷️

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.33%. Comparing base (f4d3e70) to head (f2acf50).
Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##             main      #68   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files          15       15           
  Lines        3367     3367           
=======================================
  Hits         3311     3311           
  Misses         56       56           
Files with missing lines Coverage Δ
...nt-config-bananass/src/rules/eslint-suggestions.js 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4d3e70...f2acf50. Read the comment docs.

@lumirlumir lumirlumir merged commit 3659caa into main Jan 12, 2025
4 checks passed
@lumirlumir lumirlumir deleted the fix-enforce-jsx-usage-in-no-unused-expressions branch January 12, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant