Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-config-bananass-react): create eslint-config-bananass-react package #70

Merged
merged 11 commits into from
Jan 14, 2025

Conversation

lumirlumir
Copy link
Owner

@lumirlumir lumirlumir commented Jan 14, 2025

This pull request introduces a new ESLint configuration package specifically for React, named eslint-config-bananass-react. The changes include adding the new package, updating dependencies, and configuring the necessary rules and plugins for React.

Key changes include:

New ESLint Configuration Package for React:

  • Added eslint-config-bananass-react package with its own package.json file, including metadata, dependencies, and scripts.
  • Created recommended.js configuration file to extend the base bananass configuration with React-specific rules and plugins.
  • Added index.js as the entry point for the eslint-config-bananass-react package.

React-Specific Rules:

  • Defined rules for eslint-plugin-react-compiler in react-compiler.js.
  • Defined rules for eslint-plugin-react-hooks in react-hooks.js.

Dependency Updates:

  • Updated eslint.config.js and package.json to use the new eslint-config-bananass-react package. [1] [2]

@github-actions github-actions bot added the feat label Jan 14, 2025
Copy link

Labels have been automatically applied based on the conventional commit types.🏷️

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.33%. Comparing base (8dc58e6) to head (74a97bb).
Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##             main      #70   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files          15       15           
  Lines        3367     3367           
=======================================
  Hits         3311     3311           
  Misses         56       56           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dc58e6...74a97bb. Read the comment docs.

@lumirlumir lumirlumir marked this pull request as ready for review January 14, 2025 11:44
@lumirlumir lumirlumir merged commit bb4a06c into main Jan 14, 2025
3 checks passed
@lumirlumir lumirlumir deleted the feat-eslint-config-bananass-react branch January 14, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant