Function without any home envirenment vars #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51
Previously even when
--no-cachewas set, we were trying to evaluate a default value for--cachebased on$HOMEor$XDG_CACHE_HOME. In the event neither was set (as happens for example in some hook environments) we were failing to even parse a default value.This adds another fallback if those home environments done provide a hint about where to put the cache: we just put it in the current directory.
Notably having this as a fallback default also allows
--no-cacheto work, since we can reliably get past setting a default cache config option we also get to the point where we can disable it. If writing to the CWD is not desired (e.g. from SVN hooks) either set a preferred location or disable the cache.