Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oga adapter support #235

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Oga adapter support #235

merged 2 commits into from
Jan 7, 2025

Conversation

suleman-uzair
Copy link
Member

This PR supports the Oga adapter for XML serialization.

@suleman-uzair suleman-uzair force-pushed the feature/oga_adapter_support branch from a0fec2f to 5687be1 Compare January 6, 2025 11:29
@suleman-uzair suleman-uzair changed the title [WIP] Oga adapter support Oga adapter support Jan 6, 2025
@suleman-uzair suleman-uzair marked this pull request as ready for review January 6, 2025 15:07
@ronaldtse
Copy link
Contributor

@suleman-uzair is there any reason to implement a custom adapter instead of using Moxml?

Copy link
Contributor

@ronaldtse ronaldtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Let's merge it first. Thank you @suleman-uzair !

@ronaldtse ronaldtse merged commit 5e95c6e into main Jan 7, 2025
2 checks passed
@ronaldtse ronaldtse deleted the feature/oga_adapter_support branch January 7, 2025 03:38
@suleman-uzair
Copy link
Member Author

is there any reason to implement a custom adapter instead of using Moxml?

@ronaldtse, I’m currently working on migrating to Moxml.

I opened this PR for the Plurimath-JS release as the work was already done & it’s now related to plurimath/plurimath#316 as well.

@ronaldtse
Copy link
Contributor

Thank you @suleman-uzair !

@suleman-uzair
Copy link
Member Author

@ronaldtse just released version 0.5.0.

@ronaldtse
Copy link
Contributor

Thanks @suleman-uzair !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants