use parent unlink class for file helper

luyadev · Apr 1, 2019 · fd689db · fd689db
1 parent 7e53169
commit fd689db
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/core/helpers/FileHelper.php b/core/helpers/FileHelper.php
@@ -198,10 +198,12 @@ public static function getFileContent($fileName)
      */
     public static function unlink($file)
     {
-        // default unlink
-        if (@unlink($file)) {
-            return true;
-        }
+        // no errors should be thrown, return false instead.
+        try {
+            if (parent::unlink($file)) {
+                return true;
+            }
+        } catch (\Exception $e) {}
 
         // try to force symlinks
         if (is_link($file)) {

diff --git a/tests/core/helpers/FileHelperTest.php b/tests/core/helpers/FileHelperTest.php
@@ -75,6 +75,11 @@ public function testGetFileContent()
 
         $this->assertFalse(FileHelper::getFileContent('doesNotExist.txt'));
     }
+
+    public function testUnlink()
+    {
+        $this->assertFalse(FileHelper::unlink('doesnotexsts.jpg'));
+    }
 
     public function testClassInfo()
     {