put automated PRs in slow queue (#753)

lyft · May 7, 2024 · 3910895 · 3910895
1 parent 6229197
commit 3910895
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 4 deletions.
diff --git a/server/neptune/lyft/activities/github.go b/server/neptune/lyft/activities/github.go
@@ -44,9 +44,11 @@ func (a *Github) GithubListPRs(ctx context.Context, request ListPRsRequest) (Lis
 
 	pullRequests := []internal.PullRequest{}
 	for _, pullRequest := range prs {
+		isAutomated := IsPRAutomated(pullRequest)
 		pullRequests = append(pullRequests, internal.PullRequest{
-			Number:    pullRequest.GetNumber(),
-			UpdatedAt: pullRequest.GetUpdatedAt(),
+			Number:        pullRequest.GetNumber(),
+			UpdatedAt:     pullRequest.GetUpdatedAt(),
+			IsAutomatedPR: isAutomated,
 		})
 	}
 
@@ -55,6 +57,18 @@ func (a *Github) GithubListPRs(ctx context.Context, request ListPRsRequest) (Lis
 	}, nil
 }
 
+func IsPRAutomated(pr *github.PullRequest) bool {
+	if pr == nil || len(pr.Labels) == 0 {
+		return false
+	}
+	for _, label := range pr.Labels {
+		if label.GetName() == "automated" {
+			return true
+		}
+	}
+	return false
+}
+
 type ListModifiedFilesRequest struct {
 	Repo        internal.Repo
 	PullRequest internal.PullRequest

diff --git a/server/neptune/lyft/workflows/prrevision/workflow.go b/server/neptune/lyft/workflows/prrevision/workflow.go
@@ -132,8 +132,8 @@ func (r *Runner) listModifiedFilesAsync(ctx workflow.Context, req Request, prs [
 	oldPRCounter := r.Scope.SubScope("open_prs").Counter(fmt.Sprintf("more_than_%d_days", r.SlowProcessingCutOffDays))
 	newPRCounter := r.Scope.SubScope("open_prs").Counter(fmt.Sprintf("less_than_%d_days", r.SlowProcessingCutOffDays))
 	for _, pr := range prs {
-		// schedule on slow tq if pr is not updated within x days
-		if !r.isPrUpdatedWithinDays(ctx, pr, r.SlowProcessingCutOffDays) {
+		// schedule on slow tq if pr is not updated within x days, or if its an automated PR (aka refactorator PR, a PR with the label "automated")
+		if !r.isPrUpdatedWithinDays(ctx, pr, r.SlowProcessingCutOffDays) || pr.IsAutomatedPR {
 			options := workflow.GetActivityOptions(ctx)
 			options.TaskQueue = SlowTaskQueue
 			ctx = workflow.WithActivityOptions(ctx, options)

diff --git a/server/neptune/workflows/activities/github/pull.go b/server/neptune/workflows/activities/github/pull.go
@@ -8,6 +8,8 @@ import (
 type PullRequest struct {
 	Number    int
 	UpdatedAt time.Time
+	// Whether the PR has a label of "automated" or not, useful for identifying refactorator PRs
+	IsAutomatedPR bool
 }
 
 type PullRequestState string