use int instead of string for app id since its a number and we need t…

…o read it in correctly in the env var (#755)
lyft · May 16, 2024 · ff5fcfb · ff5fcfb
1 parent 6df4247
commit ff5fcfb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/server/config/raw/global_cfg.go b/server/config/raw/global_cfg.go
@@ -32,7 +32,7 @@ type GlobalCfg struct {
 
 type ExtraGithubRateLimit struct {
 	GHSlug   string `yaml:"gh_slug" json:"gh_slug"`
-	GHAppID  string `yaml:"gh_app_id" json:"gh_app_id"`
+	GHAppID  int    `yaml:"gh_app_id" json:"gh_app_id"`
 	GHAppKey string `yaml:"gh_app_key" json:"gh_app_key"`
 }
 

diff --git a/server/config/valid/global_cfg.go b/server/config/valid/global_cfg.go
@@ -68,9 +68,10 @@ type GlobalCfg struct {
 	ExtraGithubRateLimit ExtraGithubRateLimit
 }
 
+// This is here for using an extra github app
 type ExtraGithubRateLimit struct {
 	GHSlug   string
-	GHAppID  string
+	GHAppID  int // note that this is also known as the "integration ID"
 	GHAppKey string
 }