fix SEV 16399 #765
Merged
fix SEV 16399 #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tested on staging |
asubrocky
previously approved these changes
Jul 24, 2024
asubrocky
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes SEV16399. This PR https://github.com/lyft/atlantis/pull/764/files was causing the issue, but it turns out the issue was actually caused by https://github.com/lyft/atlantis/pull/763/files , as when it was made I was not aware of the always false allocator being used by the gateway in the github client (note there are 2 feature allocators being used, one in the githubclient (always false) and the normal one in the NewVCSEventsController() (which is always true in our case because of https://github.com/lyft/atlantis-dynamic-config).