Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTPROD-9204] Allow Match By Bot User ID #106

Merged
merged 8 commits into from
Apr 5, 2024
Merged

Conversation

colinsl
Copy link
Contributor

@colinsl colinsl commented Apr 4, 2024

This pull request includes changes to the omnibot service and its documentation. The changes mainly revolve around the addition of a user_id property in the Bot class, the modification of the _parse_payload method in the Message class to include a check for the bot's user_id, and the addition of important notes in the Adding normal slack apps documentation.

Documentation Updates:

  • docs/root/adding_new_slack_apps.rst: Added notes about the potential for the bot to be called twice if app_mention is added, the need for bot.name to match the app user_handle, and the need to specify match_mention: true if user_handle and bot.name do not match.

Codebase Updates:

@colinsl
Copy link
Contributor Author

colinsl commented Apr 4, 2024

PTAL @ryand0 @david-lyft @toverturf-lyft

@colinsl colinsl force-pushed the colinsl/match-bot-user-id branch from 5535fd3 to 8eceba8 Compare April 5, 2024 01:15
david-lyft
david-lyft previously approved these changes Apr 5, 2024
omnibot/services/slack/__init__.py Outdated Show resolved Hide resolved
@colinsl colinsl merged commit 744b246 into master Apr 5, 2024
5 checks passed
@colinsl colinsl deleted the colinsl/match-bot-user-id branch April 5, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants