Fix class variable typo

m-czernek · Mar 21, 2020 · ec8ca88 · ec8ca88
1 parent 3dbf5a8
commit ec8ca88
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/src/main/java/com/redhat/constants/Constants.java b/src/main/java/com/redhat/constants/Constants.java
@@ -34,4 +34,7 @@ public class Constants {
             "https://github.com/m-czernek/acrobot \n\n" +
             "Currently, Acrobot is testing injecting IRC acronym database into the results. For feedback, comments, or suggestions "+
             "about the function, visit https://github.com/m-czernek/acrobot/pull/12";
+
+    public static final String FOUND_YAML_TEXT = "\n_Found requested acronym in the IRC database. " +
+            "Send @Acrobot help for more information about this feature._\n";
 }
diff --git a/src/main/java/com/redhat/messages/YamlAcrobotInjector.java b/src/main/java/com/redhat/messages/YamlAcrobotInjector.java
@@ -1,6 +1,7 @@
 package com.redhat.messages;
 
 import com.fasterxml.jackson.databind.JsonNode;
+import com.redhat.constants.Constants;
 import com.redhat.entities.Acronym;
 import com.redhat.entities.Explanation;
 import com.redhat.persistence.YamlDal;
@@ -9,9 +10,9 @@
 
 public class YamlAcrobotInjector {
     private YamlDal dal = new YamlDal();
-    String res = "\n_Found requested acronym in the IRC database. Send @Acrobot help for more information about this feature._\n";
 
     public String injectYamlAcronyms(JsonNode eventJson, String originalMessage) {
+        String res = Constants.FOUND_YAML_TEXT;
         String requestedAcronym = eventJson.get("message").get("argumentText").asText().trim();
         Set<Acronym> yamlAcronyms = dal.getAcronymsByName(requestedAcronym);
 

diff --git a/src/main/java/com/redhat/persistence/YamlDal.java b/src/main/java/com/redhat/persistence/YamlDal.java
@@ -16,7 +16,7 @@
 import java.util.Set;
 
 public class YamlDal {
-    Map<String, Map<String, String>> yamlDatabase;
+    private Map<String, Map<String, String>> yamlDatabase;
 
 
     public YamlDal() {