This repository has been archived by the owner on May 13, 2024. It is now read-only.
WIP:Inject acronyms from IRC acrobot database into GChat response #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-czernek
force-pushed
the
yamlDataSource
branch
from
b51e402 to
44c9f71
Compare
|
Missing integration tests of both YAML and DB source at once. Unit tests for DB and YAML present. Changing to WIP till then. |
m-czernek
changed the title
added 10 commits
June 17, 2020 11:33
m-czernek
force-pushed
the
yamlDataSource
branch
from
a127fec to
8a2134a
Compare
|
Fixed a small NPE issue; deployed into prod and realized tests are missing for room interactions. Still WIP for now; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR will check acronyms against the IRC maintained database at [1], and if an acronym is found in the database, it is injected into the response. Consequently, users will get both acronyms from internally maintained database as well as the publicly-maintained database used for the IRC bot.
The feature is currently deployed and being tested in production setting. Should there be no objections by the users, it will be merged into master.
[1] https://github.com/theacrobot/AcroBot/blob/master/data/abbrev.yaml