added @functools.wraps(run_func) to task_complete_check_wrapper #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
|
@mski-iksm Can we have any kind of unit test ? I'm not sure what problem happen if decorate function name changed. (but yes, sounds problem 😅 I's great if we have concrete problem case and confirm it is prevented |
|
@yokomotod So there is no concrete problem case, and therefore I think no test is required. |
|
I see, then I agree to not have unit test for and +1 for using |
yokomotod
approved these changes
Dec 28, 2023
Hi-king
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added @functools.wraps not to change wrapped function's name.