Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Communicate Inner Task Exceptions as Part of GokartBuildError #418

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Communicate Inner Task Exceptions as Part of GokartBuildError #418

wants to merge 3 commits into from
+22 −3

Conversation

Hi-king
Copy link
Member

@Hi-king Hi-king commented Dec 20, 2024 •
edited
Loading

This PR improves error transparency in the gokart.build process by modifying how errors are captured and reported. Instead of simply throwing a GokartBuildError when a task fails, the change includes the specific exceptions raised by each task within the error itself. This is achieved by collecting exceptions through an event handler and appending them to a GokartBuildError.

Changes:

  • Updated the GokartBuildError class to include a raised_exceptions property, which is a dictionary mapping task unique IDs to lists of exceptions that occurred.

@Hi-king Hi-king changed the title Draft: Pass child exceptions to gokart.build Draft: Pass inner task exceptions to gokart.build Dec 20, 2024
@Hi-king Hi-king force-pushed the feature/child_exception_to_build branch from 029596b to 5ee8018 Compare January 1, 2025 16:13
@Hi-king Hi-king changed the title Draft: Pass inner task exceptions to gokart.build Pass inner task exceptions outside to gokart.build Jan 10, 2025
@Hi-king Hi-king changed the title Pass inner task exceptions outside to gokart.build Communicate Inner Task Exceptions as Part of gokart.build Errors Jan 10, 2025
@Hi-king Hi-king changed the title Communicate Inner Task Exceptions as Part of gokart.build Errors Communicate Inner Task Exceptions as Part of GokartBuildError Jan 10, 2025
@Hi-king Hi-king force-pushed the feature/child_exception_to_build branch from 8b7080b to 5fb6c50 Compare January 10, 2025 09:57
@hiro-o918
Copy link
Contributor

Nice!
I'm looking forward to use this😆

hirosassa
hirosassa approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@hirosassa hirosassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Hi-king
Copy link
Member Author

Hi-king commented Jan 10, 2025

@hiro-o918 @hirosassa Thank you for your quick review !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiro-o918 hiro-o918 hiro-o918 approved these changes

@hirosassa hirosassa hirosassa approved these changes

@kitagry kitagry Awaiting requested review from kitagry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hi-king @hiro-o918 @hirosassa