Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.NET Standard 1.3 Support (.NET Core, UWP, etc) #297

Merged
merged 16 commits into from
Jul 30, 2016
Merged

.NET Standard 1.3 Support (.NET Core, UWP, etc) #297

merged 16 commits into from
Jul 30, 2016

Conversation

ivanz
Copy link
Contributor

@ivanz ivanz commented Jul 28, 2016 •
edited
Loading

Early preview/work in progress pull request to see the changes for .NET Standard support:

  • Backwards compatible in the ".NET" target
  • Tests pass locally and in CI
    • Port tests
    • Run NUnit tests on both .NET and .NET Core (and in CI)
    • Run MSpec tests on both .NET and .NET Core (and in CI)
      • Create a replacement of the Remoting over AppDomains for machine.specifications.runner.utility in order to be able to update and use dotnet-test-mspec

Some notes:

  • Assembly.Location is not supported in UWP and .NET STandard 1.3 accordingly.

Work items: #280 , #296 , #286

@ivanz ivanz added this to the 0.10.0 ".Net Core / .Net Standard" support milestone Jul 28, 2016
@ivanz ivanz mentioned this pull request Jul 28, 2016
Closed
@ivanz ivanz force-pushed the feature/dotnet-core-standard-port branch from a240f04 to 7d84598 Compare July 28, 2016 17:43
@ivanz ivanz force-pushed the feature/dotnet-core-standard-port branch 2 times, most recently from 91e61f7 to 04507ae Compare July 28, 2016 22:36
@ivanz ivanz force-pushed the feature/dotnet-core-standard-port branch 3 times, most recently from c5a6a0f to f6d270c Compare July 29, 2016 17:32
@ivanz ivanz changed the title [WIP] .NET Standard 1.3 (.NET Core/UWP/UAP support) .NET Standard 1.3 Support (.NET Core, UWP, etc) Jul 29, 2016
@ivanz
Copy link
Contributor Author

ivanz commented Jul 29, 2016

This is now complete @einari

@ivanz ivanz force-pushed the feature/dotnet-core-standard-port branch from 6edc8cf to f911c64 Compare July 30, 2016 10:54
@ivanz ivanz removed the in progress label Jul 30, 2016
@ivanz ivanz mentioned this pull request Jul 30, 2016
Closed
16 tasks
@ivanz ivanz force-pushed the feature/dotnet-core-standard-port branch from d80b82f to 5cb582c Compare July 30, 2016 15:21
@einari
Copy link
Contributor

einari commented Jul 30, 2016

Looks good! Merge it in.

@ivanz ivanz merged commit b903624 into machine:develop Jul 30, 2016
@ivanz ivanz mentioned this pull request Jul 30, 2016
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Target: NET Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanz @einari