Simplify into a bigger case statement

maciej-szlosarczyk · Dec 20, 2016 · b73c3de · b73c3de
1 parent ac071c4
commit b73c3de
Showing 1 changed file with 7 additions and 9 deletions.
diff --git a/lib/terjira/client/jql_builder.rb b/lib/terjira/client/jql_builder.rb
@@ -10,18 +10,16 @@ def build_jql(options = {})
         end.slice(*JQL_KEYS)
 
         query = q_options.map do |key, value|
-          if value.is_a? Array
+          case
+          when value.is_a?(Array)
             values = value.map { |v| "\"#{v.key_value}\"" }.join(',')
             "#{key} IN (#{values})"
+          when value.key_value.to_s =~ /^\d+$/
+            "#{key}=#{value.key_value}"
+          when key.eql?('summary')
+            "#{key}~\"#{value.key_value}\""
           else
-            case
-            when value.key_value.to_s =~ /^\d+$/
-              "#{key}=#{value.key_value}"
-            when key.eql?('summary')
-              "#{key}~\"#{value.key_value}\""
-            else
-              "#{key}=\"#{value.key_value}\""
-            end
+            "#{key}=\"#{value.key_value}\""
           end
         end.reject(&:blank?).join(' AND ')