Aaudio state transition fix #916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile stream is closed from another thread.
|
Thanks a lot for this. I have been reading all of your messages as they've come through. Will get to this as soon as I get a chance. |
|
Just FYI, I've changed the base branch from master to dev for this PR so I don't accidentally merge into the master branch. Don't think there should be any issues. |
|
Right. So after some testing I can confirm that the fix doesn't work (audio gets muted). I'm suspecing the timeout of 5 seconds, so I'll try without it. |
|
These changes proved to be useless. Closing. See discussion in #913. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #913. An intermittent crash in
AAudiowhen waiting for state transition while the stream is closed from another thread. The symptom is usually that theAndroidapp crashes immediately when resumed after a lengthy period (usually hours).Adapting same logic as seen in oboe, but preserving the previous timeout of 5 seconds.
@mackron, please verify the correctness of the thread/state synchronization.
Testing is ongoing! I expect to have some results ready within a couple of days. All in all, I'm confident that the logic is correct.