Skip to content

Commit

Permalink
Perform checks for CRAN. (#21)
Browse files Browse the repository at this point in the history
Also see previous PR for the actual changes. Sorry about that, I'm out of practice (as far as working with a reviewer)!
  • Loading branch information
jonthegeek authored Jun 2, 2023
1 parent 6850eea commit 36a7825
Show file tree
Hide file tree
Showing 9 changed files with 85 additions and 8 deletions.
1 change: 1 addition & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@
^_pkgdown\.yml$
^docs$
^pkgdown$
^revdep$
4 changes: 4 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# piecemaker 1.0.2

* Streamlined `validate_utf8()` to work consistently across OS and R versions.

# piecemaker 1.0.1

* Removed purrr dependency.
Expand Down
35 changes: 27 additions & 8 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,30 +2,49 @@

## Changes

* Removed purrr dependency.
* Streamlined `validate_utf8()` to work consistently across OS and R versions.

## R CMD check results

0 errors | 0 warnings | 0 notes

## Test environments

* local R installation, R 4.1.2 (Windows 10)
* local R installation, R 4.3.0 (Windows 11)
* win-builder (devel)
* Windows Server 2022, R-devel, 64 bit (rhub)
* Ubuntu Linux 20.04.1 LTS, R-release, GCC (rhub)
* Fedora Linux, R-devel, clang, gfortran (rhub)

There is a NOTE when testing for Windows Server:
### Windows

There are NOTEs when testing for Windows Server:

```
* checking for non-standard things in the check directory ... NOTE
Found the following files/directories:
''NULL''
* checking for detritus in the temp directory ... NOTE
Found the following files/directories:
'lastMiKTeXException'
```

I cannot reproduce this error on my Windows machine, and a web search indicated that it is likely nothing. I can't find anything that could possibly trigger that error.
I cannot reproduce these errors on my Windows machine, and a web search indicated that it is likely nothing. I can't find anything that could possibly trigger that error.

## R CMD check results
### Linux

0 errors | 0 warnings | 0 notes
Both Linux checks also returned this note:

```
* checking HTML version of manual ... NOTE
Skipping checking HTML validation: no command 'tidy' found
```

This note also appears to be a false alarm.

## revdepcheck results

## Reverse dependencies
We checked 2 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.

wordpiece and morphemepiece are not impacted by this change.
* We saw 0 new problems
* We failed to check 0 packages
7 changes: 7 additions & 0 deletions revdep/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
checks
library
checks.noindex
library.noindex
cloud.noindex
data.sqlite
*.html
32 changes: 32 additions & 0 deletions revdep/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# Platform

|field |value |
|:--------|:--------------------------------------|
|version |R version 4.3.0 (2023-04-21 ucrt) |
|os |Windows 11 x64 (build 22621) |
|system |x86_64, mingw32 |
|ui |RStudio |
|language |(EN) |
|collate |English_United States.utf8 |
|ctype |English_United States.utf8 |
|tz |America/Chicago |
|date |2023-06-01 |
|rstudio |2023.03.1+446 Cherry Blossom (desktop) |
|pandoc |NA |

# Dependencies

|package |old |new |Δ |
|:----------|:------|:------|:--|
|piecemaker |1.0.1 |1.0.2 |* |
|cli |3.6.1 |3.6.1 | |
|glue |1.6.2 |1.6.2 | |
|lifecycle |1.0.3 |1.0.3 | |
|magrittr |2.0.3 |2.0.3 | |
|rlang |1.1.1 |1.1.1 | |
|stringi |1.7.12 |1.7.12 | |
|stringr |1.5.0 |1.5.0 | |
|vctrs |0.6.2 |0.6.2 | |

# Revdeps

7 changes: 7 additions & 0 deletions revdep/cran.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
## revdepcheck results

We checked 2 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.

* We saw 0 new problems
* We failed to check 0 packages

5 changes: 5 additions & 0 deletions revdep/email.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
release_date: ???
rel_release_date: ???
my_news_url: ???
release_version: ???
release_details: ???
1 change: 1 addition & 0 deletions revdep/failures.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
*Wow, no problems at all. :)*
1 change: 1 addition & 0 deletions revdep/problems.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
*Wow, no problems at all. :)*

0 comments on commit 36a7825

Please sign in to comment.