Multiple, Interdependent Python Image Processing Ports: py-opencv, etc. #6261

essandess · 2020-01-28T23:28:11Z

Multiple Python Image Processing Ports: py-opencv, etc.

python/py-codecov/Portfile
python/py-imutils/Portfile
python/py-moviepy/Portfile
python/py-opencv/Portfile
python/py-photomosaic/Portfile
python/py-proglog/Portfile
python/py-pytest-fixture-config/Portfile
python/py-pytest-mock/Portfile
python/py-pytest-shutil/Portfile
python/py-pytest-virtualenv/Portfile

Description

Type(s)

bugfix
enhancement
security fix

Tested on

macOS 10.x
Xcode 8.x

Verification

Have you

followed our Commit Message Guidelines?
squashed and minimized your commits?
checked that there aren't other open pull requests for the same change?
referenced existing tickets on Trac with full URL?

checked your Portfile with port lint?
tried existing tests with sudo port test?
tried a full install with sudo port -vst install?
tested basic functionality of all binary files?

macportsbot · 2020-01-28T23:28:15Z

Notifying maintainers:
@beauby for port libfaiss.
@stromnov for port py-scikit-build.
@mdouze for port libfaiss.

macportsbot · 2020-01-29T03:51:48Z

Travis Build #10157 Errored.

Lint results

--->  Verifying Portfile for libfaiss
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-codecov
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-dlib
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-faiss
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-imutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-moviepy
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-opencv
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-photomosaic
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-proglog
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pytest-fixture-config
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pytest-mock
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pytest-shutil
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pytest-virtualenv
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-scikit-build
--->  0 errors and 0 warnings found.

Port libfaiss success on xcode10.3. Log
Port py37-codecov success on xcode10.3. Log
Port py-codecov success on xcode10.3. Log
Port py38-codecov success on xcode10.3. Log
Port py37-dlib success on xcode10.3. Log
Port py-dlib success on xcode10.3. Log
Port py38-dlib fail on xcode10.3. Log
Port libfaiss success on xcode9.4. Log
Port py37-codecov success on xcode9.4. Log
Port py-codecov success on xcode9.4. Log
Port py38-codecov success on xcode9.4. Log
Port py37-dlib success on xcode9.4. Log
Port py-dlib success on xcode9.4. Log
Port py38-dlib fail on xcode9.4. Log
Port py37-faiss success on xcode9.4. Log
Port libfaiss success on xcode8.3. Log
Port py37-codecov success on xcode8.3. Log
Port py-codecov success on xcode8.3. Log
Port py38-codecov success on xcode8.3. Log
Port py37-dlib success on xcode8.3. Log
Port py-dlib success on xcode8.3. Log
Port py38-dlib fail on xcode8.3. Log
Port py37-faiss success on xcode8.3. Log
Port py-faiss success on xcode8.3. Log
Port libfaiss success on xcode7.3. Log
Port py37-codecov success on xcode7.3. Log
Port py-codecov success on xcode7.3. Log
Port py38-codecov success on xcode7.3. Log
Port py37-dlib fail on xcode7.3. Log
Port py-dlib's dependencies fail on xcode7.3. Log
Port py38-dlib fail on xcode7.3. Log

The build timed out.

macportsbot · 2020-01-29T13:34:31Z

Travis Build #10163 Errored.

Lint results

--->  Verifying Portfile for libfaiss
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-codecov
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-dlib
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-faiss
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-imutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-moviepy
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-opencv
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-photomosaic
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-proglog
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pytest-fixture-config
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pytest-mock
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pytest-shutil
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pytest-virtualenv
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-scikit-build
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-setuptools-git
--->  0 errors and 0 warnings found.

Port libfaiss success on xcode10.3. Log
Port py37-codecov success on xcode10.3. Log
Port py-codecov success on xcode10.3. Log
Port py38-codecov success on xcode10.3. Log
Port py37-dlib success on xcode10.3. Log
Port libfaiss success on xcode9.4. Log
Port py37-codecov success on xcode9.4. Log
Port py-codecov success on xcode9.4. Log
Port py38-codecov success on xcode9.4. Log
Port py37-dlib success on xcode9.4. Log
Port py-dlib success on xcode9.4. Log
Port py38-dlib success on xcode9.4. Log
Port libfaiss success on xcode8.3. Log
Port py37-codecov success on xcode8.3. Log
Port py-codecov success on xcode8.3. Log
Port py38-codecov success on xcode8.3. Log
Port py37-dlib success on xcode8.3. Log
Port py-dlib success on xcode8.3. Log
Port py38-dlib success on xcode8.3. Log
Port libfaiss success on xcode7.3. Log
Port py37-codecov success on xcode7.3. Log
Port py-codecov success on xcode7.3. Log
Port py38-codecov success on xcode7.3. Log
Port py37-dlib fail on xcode7.3. Log
Port py-dlib's dependencies fail on xcode7.3. Log
Port py38-dlib fail on xcode7.3. Log

The build timed out.

macportsbot · 2020-01-29T21:08:06Z

Travis Build #10172 Errored.

Lint results

--->  Verifying Portfile for libfaiss
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-codecov
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-dlib
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-faiss
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-imutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-moviepy
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-opencv
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-photomosaic
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-proglog
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pytest-fixture-config
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pytest-mock
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pytest-shutil
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pytest-virtualenv
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-scikit-build
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-setuptools-git
--->  0 errors and 0 warnings found.

Port libfaiss success on xcode10.3. Log
Port py37-codecov success on xcode10.3. Log
Port py-codecov success on xcode10.3. Log
Port py38-codecov success on xcode10.3. Log
Port libfaiss success on xcode9.4. Log
Port py37-codecov success on xcode9.4. Log
Port py-codecov success on xcode9.4. Log
Port py38-codecov success on xcode9.4. Log
Port py37-dlib success on xcode9.4. Log
Port py-dlib success on xcode9.4. Log
Port libfaiss success on xcode8.3. Log
Port py37-codecov success on xcode8.3. Log
Port py-codecov success on xcode8.3. Log
Port py38-codecov success on xcode8.3. Log
Port py37-dlib success on xcode8.3. Log
Port py-dlib success on xcode8.3. Log
Port libfaiss success on xcode7.3. Log
Port py37-codecov success on xcode7.3. Log
Port py-codecov success on xcode7.3. Log
Port py38-codecov success on xcode7.3. Log
Port py37-dlib fail on xcode7.3. Log
Port py-dlib's dependencies fail on xcode7.3. Log
Port py38-dlib fail on xcode7.3. Log

The build timed out.

macportsbot · 2020-01-30T03:36:16Z

Travis Build #10176 Errored.

Lint results

--->  Verifying Portfile for libfaiss
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-codecov
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-dlib
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-faiss
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-imutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-moviepy
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-opencv
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-photomosaic
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-proglog
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pytest-fixture-config
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pytest-mock
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pytest-shutil
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pytest-virtualenv
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-scikit-build
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-setuptools-git
--->  0 errors and 0 warnings found.

Port libfaiss success on xcode10.3. Log
Port py37-codecov success on xcode10.3. Log
Port py-codecov success on xcode10.3. Log
Port py38-codecov success on xcode10.3. Log
Port py37-dlib success on xcode10.3. Log
Port py-dlib success on xcode10.3. Log
Port libfaiss success on xcode9.4. Log
Port py37-codecov success on xcode9.4. Log
Port py-codecov success on xcode9.4. Log
Port py38-codecov success on xcode9.4. Log
Port py37-dlib success on xcode9.4. Log
Port py-dlib success on xcode9.4. Log
Port py38-dlib success on xcode9.4. Log
Port libfaiss success on xcode8.3. Log
Port py37-codecov success on xcode8.3. Log
Port py-codecov success on xcode8.3. Log
Port py38-codecov success on xcode8.3. Log
Port py37-dlib success on xcode8.3. Log
Port py-dlib success on xcode8.3. Log
Port py38-dlib success on xcode8.3. Log
Port libfaiss success on xcode7.3. Log
Port py37-codecov success on xcode7.3. Log
Port py-codecov success on xcode7.3. Log
Port py38-codecov success on xcode7.3. Log
Port py37-dlib fail on xcode7.3. Log
Port py-dlib's dependencies fail on xcode7.3. Log
Port py38-dlib fail on xcode7.3. Log

The build timed out.

macportsbot · 2020-01-30T12:55:39Z

Travis Build #10179 Errored.

Lint results

--->  Verifying Portfile for libfaiss
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-codecov
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-dlib
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-faiss
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-imutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-moviepy
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-opencv
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-photomosaic
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-proglog
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pytest-fixture-config
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pytest-mock
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pytest-shutil
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pytest-virtualenv
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-scikit-build
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-setuptools-git
--->  0 errors and 0 warnings found.

Port libfaiss success on xcode10.3. Log
Port py37-codecov success on xcode10.3. Log
Port py-codecov success on xcode10.3. Log
Port py38-codecov success on xcode10.3. Log
Port py37-dlib success on xcode10.3. Log
Port py-dlib success on xcode10.3. Log
Port libfaiss success on xcode9.4. Log
Port py37-codecov success on xcode9.4. Log
Port py-codecov success on xcode9.4. Log
Port py38-codecov success on xcode9.4. Log
Port py37-dlib success on xcode9.4. Log
Port py-dlib success on xcode9.4. Log
Port py38-dlib success on xcode9.4. Log
Port libfaiss success on xcode8.3. Log
Port py37-codecov success on xcode8.3. Log
Port py-codecov success on xcode8.3. Log
Port py38-codecov success on xcode8.3. Log
Port py37-dlib success on xcode8.3. Log
Port py-dlib success on xcode8.3. Log
Port py38-dlib success on xcode8.3. Log
Port libfaiss success on xcode7.3. Log
Port py37-codecov success on xcode7.3. Log
Port py-codecov success on xcode7.3. Log
Port py38-codecov success on xcode7.3. Log
Port py37-dlib fail on xcode7.3. Log
Port py-dlib's dependencies fail on xcode7.3. Log
Port py38-dlib fail on xcode7.3. Log

The build timed out.

essandess · 2020-02-16T12:22:20Z

@reneeotten I’ll do my best to apply your advice from #6314 (comment) to this PR in the next days/weeks.

Suggestion: please find a good place to permanently document these pointers for Python Portfiles, so that they’re not in obscure PR threads.

macportsbot · 2020-02-19T00:05:21Z

Travis Build #10469 Errored.

Lint results

--->  Verifying Portfile for libfaiss
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-codecov
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-dlib
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-faiss
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-imutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-moviepy
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-opencv
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-photomosaic
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-proglog
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pytest-fixture-config
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pytest-mock
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pytest-shutil
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pytest-virtualenv
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-scikit-build
--->  0 errors and 0 warnings found.

Port libfaiss success on xcode10.3. Log
Port py37-codecov success on xcode10.3. Log
Port py-codecov success on xcode10.3. Log
Port py38-codecov success on xcode10.3. Log
Port libfaiss success on xcode9.4. Log
Port py37-codecov success on xcode9.4. Log
Port py-codecov success on xcode9.4. Log
Port py38-codecov success on xcode9.4. Log
Port py37-dlib success on xcode9.4. Log
Port py-dlib success on xcode9.4. Log
Port libfaiss success on xcode8.3. Log
Port py37-codecov success on xcode8.3. Log
Port py-codecov success on xcode8.3. Log
Port py38-codecov success on xcode8.3. Log
Port py37-dlib success on xcode8.3. Log
Port py-dlib success on xcode8.3. Log
Port libfaiss success on xcode7.3. Log
Port py37-codecov success on xcode7.3. Log
Port py-codecov success on xcode7.3. Log
Port py38-codecov success on xcode7.3. Log
Port py37-dlib fail on xcode7.3. Log
Port py-dlib's dependencies fail on xcode7.3. Log
Port py38-dlib fail on xcode7.3. Log

The build timed out.

macportsbot · 2020-02-19T01:47:56Z

Travis Build #10470 Errored.

Lint results

--->  Verifying Portfile for libfaiss
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-codecov
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-dlib
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-faiss
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-imutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-moviepy
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-opencv
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-photomosaic
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-proglog
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pytest-fixture-config
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pytest-mock
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pytest-shutil
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pytest-virtualenv
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-scikit-build
--->  0 errors and 0 warnings found.

Port libfaiss success on xcode10.3. Log
Port py37-codecov success on xcode10.3. Log
Port py-codecov success on xcode10.3. Log
Port py38-codecov success on xcode10.3. Log
Port py37-dlib success on xcode10.3. Log
Port py-dlib success on xcode10.3. Log
Port libfaiss success on xcode9.4. Log
Port py37-codecov success on xcode9.4. Log
Port py-codecov success on xcode9.4. Log
Port py38-codecov success on xcode9.4. Log
Port py37-dlib success on xcode9.4. Log
Port py-dlib success on xcode9.4. Log
Port libfaiss success on xcode8.3. Log
Port py37-codecov success on xcode8.3. Log
Port py-codecov success on xcode8.3. Log
Port py38-codecov success on xcode8.3. Log
Port py37-dlib success on xcode8.3. Log
Port py-dlib success on xcode8.3. Log
Port libfaiss success on xcode7.3. Log
Port py37-codecov success on xcode7.3. Log
Port py-codecov success on xcode7.3. Log
Port py38-codecov success on xcode7.3. Log
Port py37-dlib fail on xcode7.3. Log
Port py-dlib's dependencies fail on xcode7.3. Log
Port py38-dlib fail on xcode7.3. Log

The build timed out.

macportsbot · 2020-02-19T14:39:34Z

Travis Build #10480 Errored.

Lint results

--->  Verifying Portfile for libfaiss
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-codecov
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-dlib
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-faiss
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-imutils
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-moviepy
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-opencv
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-photomosaic
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-proglog
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pytest-fixture-config
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pytest-mock
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pytest-shutil
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-pytest-virtualenv
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-scikit-build
--->  0 errors and 0 warnings found.

Port libfaiss's dependencies fail on xcode10.3. Log
Port py37-codecov success on xcode10.3. Log
Port py-codecov success on xcode10.3. Log
Port py38-codecov success on xcode10.3. Log
Port py37-dlib success on xcode10.3. Log
Port py-dlib success on xcode10.3. Log
Port libfaiss success on xcode9.4. Log
Port py37-codecov success on xcode9.4. Log
Port py-codecov success on xcode9.4. Log
Port py38-codecov success on xcode9.4. Log
Port py37-dlib success on xcode9.4. Log
Port py-dlib success on xcode9.4. Log
Port libfaiss success on xcode8.3. Log
Port py37-codecov success on xcode8.3. Log
Port py-codecov success on xcode8.3. Log
Port py38-codecov success on xcode8.3. Log
Port py37-dlib success on xcode8.3. Log
Port py-dlib success on xcode8.3. Log
Port libfaiss success on xcode7.3. Log
Port py37-codecov success on xcode7.3. Log
Port py-codecov success on xcode7.3. Log
Port py38-codecov success on xcode7.3. Log
Port py37-dlib fail on xcode7.3. Log
Port py-dlib's dependencies fail on xcode7.3. Log
Port py38-dlib fail on xcode7.3. Log

The build timed out.

essandess · 2020-02-19T18:11:08Z

@reneeotten I’ll do my best to apply your advice from #6314 (comment) to this PR in the next days/weeks.

I believe that the submitted Portfiles in this PR all now adhere to these guidelines.

reneeotten · 2020-02-19T23:06:27Z

@reneeotten I’ll do my best to apply your advice from #6314 (comment) to this PR in the next days/weeks.

I believe that the submitted Portfiles in this PR all now adhere to these guidelines.

Great - I'll take a look, give me a day or two.

reneeotten

some review comments below.

python/py-dlib/Portfile

python/py-imutils/Portfile

python/py-pytest-mock/Portfile

python/py-opencv/Portfile

math/libfaiss/Portfile

python/py-faiss/Portfile

math/libfaiss/Portfile

essandess · 2021-01-24T13:58:18Z

passionate == good

passionate than necessary!

mascguy · 2021-01-24T19:47:45Z

Steve, I finally had a chance to review your opencv4 changes, and they look good overall. Thanks, too, for merging in the latest updates from yesterday!

Let's eliminate the copy-paste for phase post-destroot, though, by encapsulating that logic into a procedure.

Change your subport's post-destroot phase to:

        # Deconflict with port:opencv4 contents
        post-destroot {
            opencv4_post_destroot

            foreach f [exec port contents ${name}] {
                delete ${destroot}${f}
            }
        }

And change the parent port's version to - well, you already know, after seeing that - but:

proc opencv4_post_destroot {} {
    global prefix
    global destroot

    set bin_main_dir \
                    "${destroot}${prefix}/bin"
    set bin_port_dir \
                    "${destroot}${prefix}/libexec/opencv4/bin"

    # While the various configure-related options should catch everything, one or more
    # files may be missed. If so, ensure they're moved to the opencv4 bin area.
    opencv4_move_binaries \
                    ${bin_main_dir} \
                    ${bin_port_dir}

    # Create soft links for binaries, each prefixed with 'opencv4_'.
    opencv4_soft_link_binaries \
                    ${bin_main_dir} \
                    ${bin_port_dir} \
                    ${destroot} \
                    ${prefix}
}

post-destroot {
    opencv4_post_destroot
}

Be warned, I haven't actually tested these changes yet... so there could be a typo. But that's basically the gist. :-)

* Replace python* variants as py*-opencv subports to allow Portfile dependencies

essandess · 2021-01-25T02:07:33Z

@mascguy Thanks—great idea. Yes, this works and installs correctly.

For posterity, I was barking up the wrong tree trying to incorporate the source from pypi's homepage of the cv2 package.

The work you and others did providing opencv's Python bindings in this Portfile is definitely the correct approach both because it works and because it's robust.

Thanks again.

mascguy

Looks good to me, particularly the changes for port opencv4. Anyone else?

mascguy · 2021-01-25T02:16:21Z

@reneeotten Any final thoughts/comments? Given how much work Steve has put into this PR, it would be great to see it approved and merged.

kencu · 2021-01-25T05:36:06Z

OK. Looks like you guys have settled on this. The CI system will never finish building it, so here goes, and good luck!

mascguy · 2021-01-25T16:42:58Z

Thanks Ken!

And great job Steve, looking forward to collaborating with you in the future!

mascguy · 2021-01-26T00:38:39Z

Steve, none of the following is a big deal, as I'm working on more changes to the various opencv* ports anyway. So if any corrections are necessary, then no problem!

But just wanted to confirm which variant(s) should exist for your new py3x-opencv subports:

$ port info py37-opencv
py37-opencv @4.5.0_2 (graphics, science)
Variants:             debug, eigen, tests

Debug makes sense, to enable symbols in the Python bindings. But how about eigen and tests?

Also, since we're supporting multiple OpenCV versions, do you mind if I add the major version to the subport names? (Basically just appending a '4' suffix to each.)

Cheers,
-Chris

essandess · 2021-01-26T23:25:49Z

Chris,

Bottom line—I’ll defer to your preferences. FWIW, here was my thinking on these choices:

I went through all the variants, and these ones were conscious choices: debug obvs.; tests also because I believe that this also runs tests for the Python code, at least it does in the python-opencv package; eigen I had also turned on in the python-opencv package, but I believe now this is mistaken. Even that package doesn’t use it: https://github.com/skvark/opencv-python/search?q=eigen&type=issues

I am personally not a fan of keeping version numbers in port names and prefer to be up-to-date as possible, and am furthermore not aware of any dependency on, say, py-opencv3. But again I defer to your preferences.

* Depends upon: * macports#6261 * macports#7514

* Depends upon: * #6261 * #7514

macportsbot assigned stromnov Jan 28, 2020

macportsbot added maintainer: open Affects an openmaintainer port type: enhancement type: submission labels Jan 28, 2020

essandess mentioned this pull request Jan 28, 2020

py-faiss Submission and libfaiss Upgrade #5926

Closed

13 tasks

essandess force-pushed the py-opencv branch from 8bb1dc9 to d0c73bc Compare January 29, 2020 11:17

essandess force-pushed the py-opencv branch from d0c73bc to 96ae9c0 Compare January 29, 2020 18:27

essandess force-pushed the py-opencv branch from 96ae9c0 to 8674790 Compare January 30, 2020 01:53

essandess force-pushed the py-opencv branch from 8674790 to 2f9f112 Compare January 30, 2020 10:42

essandess force-pushed the py-opencv branch 4 times, most recently from 53a8c72 to b106bbb Compare February 18, 2020 22:25

essandess force-pushed the py-opencv branch from b106bbb to b455186 Compare February 19, 2020 12:36

reneeotten requested changes Feb 20, 2020

View reviewed changes

essandess mentioned this pull request Jul 13, 2020

dlib: Add Python bindings #7733

Merged

11 tasks

essandess force-pushed the py-opencv branch 2 times, most recently from 69aa329 to f59f12d Compare July 13, 2020 19:15

essandess added 8 commits January 24, 2021 08:46

py-imutils: Submission

ba1282e

py-moviepy: Submission

2cd21f3

py-photomosaic: Submission

1df13e5

py-proglog: Submission

8cab4a7

py-pytest-fixture-config: Submission

4ed5f77

py-pytest-mock: Submission

a36bd5c

py-pytest-shutil: Submission

921b71c

py-pytest-virtualenv: Submission

32465bd

essandess force-pushed the py-opencv branch from ff870ab to d7beef2 Compare January 24, 2021 13:52

essandess added 2 commits January 24, 2021 20:59

opencv4: Add opencv-python (cv2) python bindings as py*-opencv subports

81003b8

* Replace python* variants as py*-opencv subports to allow Portfile dependencies

py-imageio-ffmpeg: Submission

5b8a5cf

essandess force-pushed the py-opencv branch from d7beef2 to 5b8a5cf Compare January 25, 2021 01:59

mascguy approved these changes Jan 25, 2021

View reviewed changes

kencu merged commit 8769b70 into macports:master Jan 25, 2021

essandess deleted the py-opencv branch January 25, 2021 11:42

mascguy mentioned this pull request Jan 27, 2021

opencv3/opencv4: add/update python subports; refine file layouts for consistency #9823

Merged

11 tasks

essandess added a commit to essandess/macports-ports that referenced this pull request Mar 27, 2021

py-tensor2tensor: Submission

bde5397

* Depends upon: * macports#6261 * macports#7514

cjones051073 pushed a commit that referenced this pull request Mar 29, 2021

py-tensor2tensor: Submission

9f2d437

* Depends upon: * #6261 * #7514

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multiple, Interdependent Python Image Processing Ports: py-opencv, etc. #6261

Multiple, Interdependent Python Image Processing Ports: py-opencv, etc. #6261

essandess commented Jan 28, 2020 •

edited

Loading

macportsbot commented Jan 28, 2020

macportsbot commented Jan 29, 2020

macportsbot commented Jan 29, 2020

macportsbot commented Jan 29, 2020

macportsbot commented Jan 30, 2020

macportsbot commented Jan 30, 2020

essandess commented Feb 16, 2020

macportsbot commented Feb 19, 2020

macportsbot commented Feb 19, 2020

macportsbot commented Feb 19, 2020

essandess commented Feb 19, 2020

reneeotten commented Feb 19, 2020

reneeotten left a comment

essandess commented Jan 24, 2021

mascguy commented Jan 24, 2021 •

edited

Loading

essandess commented Jan 25, 2021

mascguy left a comment

mascguy commented Jan 25, 2021

kencu commented Jan 25, 2021

mascguy commented Jan 25, 2021

mascguy commented Jan 26, 2021

essandess commented Jan 26, 2021

Multiple, Interdependent Python Image Processing Ports: py-opencv, etc. #6261

Multiple, Interdependent Python Image Processing Ports: py-opencv, etc. #6261

Conversation

essandess commented Jan 28, 2020 • edited Loading

Description

Type(s)

Tested on

Verification

macportsbot commented Jan 28, 2020

macportsbot commented Jan 29, 2020

macportsbot commented Jan 29, 2020

macportsbot commented Jan 29, 2020

macportsbot commented Jan 30, 2020

macportsbot commented Jan 30, 2020

essandess commented Feb 16, 2020

macportsbot commented Feb 19, 2020

macportsbot commented Feb 19, 2020

macportsbot commented Feb 19, 2020

essandess commented Feb 19, 2020

reneeotten commented Feb 19, 2020

reneeotten left a comment

Choose a reason for hiding this comment

essandess commented Jan 24, 2021

mascguy commented Jan 24, 2021 • edited Loading

essandess commented Jan 25, 2021

mascguy left a comment

Choose a reason for hiding this comment

mascguy commented Jan 25, 2021

kencu commented Jan 25, 2021

mascguy commented Jan 25, 2021

mascguy commented Jan 26, 2021

essandess commented Jan 26, 2021

essandess commented Jan 28, 2020 •

edited

Loading

mascguy commented Jan 24, 2021 •

edited

Loading