fix threads issue

madara-alliance · Sep 28, 2024 · 2a074d0 · 2a074d0
1 parent e150e0c
commit 2a074d0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/.github/workflows/starknet-test.yml b/.github/workflows/starknet-test.yml
@@ -56,4 +56,4 @@ jobs:
     - name: Run Starknet tests
       run: |
         cd orchestrator
-        cargo test -p starknet-settlement-client --nocapture
+        cargo test -p starknet-settlement-client -- --nocapture --test-threads=1
diff --git a/crates/settlement-clients/starknet/src/tests/test.rs b/crates/settlement-clients/starknet/src/tests/test.rs
@@ -53,6 +53,9 @@ async fn wait_for_tx_success(
     let mut attempt = 0;
     loop {
         attempt += 1;
+        if attempt >= 5 {
+            return false;
+        }
         let reciept = match account.provider().get_transaction_status(transaction_hash).await {
             Ok(reciept) => reciept,
             Err(ProviderError::StarknetError(StarknetError::TransactionHashNotFound)) => {
@@ -74,11 +77,6 @@ async fn wait_for_tx_success(
                 TransactionExecutionStatus::Reverted => return false,
             },
         }
-
-        if attempt >= 5 {
-            return false;
-        }
-
         // This is done, since currently madara does not increment nonce for pending transactions
         tokio::time::sleep(duration).await;
     }