move starknet settlement to zaun #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
byteZorvin
commented
Sep 18, 2024
byteZorvin
commented
- Orchestrator now uses zaun types now to interact with starknet core contract.
apoorvsadana
reviewed
Oct 4, 2024
.env.example
Outdated
|
|
||
|
|
||
| ##### STARKNET SETTLEMENT TEST ##### |
There was a problem hiding this comment.
Suggested change
| ##### STARKNET SETTLEMENT TEST ##### | |
| ##### STARKNET SETTLEMENT (L3s) ##### |
.github/workflows/coverage.yml
Outdated
Comment on lines
83
to
84
| repository: madara-alliance/madara # Replace with your first repository | ||
| ref: "0c821aecd1cafc516d00548473fcaddaa4dc0ce4" # Replace with your branch name |
There was a problem hiding this comment.
Suggested change
| repository: madara-alliance/madara # Replace with your first repository | |
| ref: "0c821aecd1cafc516d00548473fcaddaa4dc0ce4" # Replace with your branch name | |
| repository: madara-alliance/madara | |
| ref: "0c821aecd1cafc516d00548473fcaddaa4dc0ce4" |
| @@ -197,11 +206,26 @@ impl SettlementClient for StarknetSettlementClient { | |||
| if block_number.is_empty() { | |||
| return Err(eyre!("Could not fetch last block number from core contract.")); | |||
| } | |||
| Ok(block_number[0].try_into()?) | |||
|
|
|||
| Ok(u64::from_le_bytes(block_number[0].to_bytes_le()[0..8].try_into().unwrap())) | |||
| } | |||
|
|
|||
| /// Returns the nonce for the wallet in use. | |||
| async fn get_nonce(&self) -> Result<u64> { | |||
| todo!("Yet to impl nonce call for Starknet.") | |||
There was a problem hiding this comment.
i would ideally add a small test case for this :)
| node | ||
| } | ||
|
|
||
| async fn wait_for_tx_success( |
| use utils::settings::Settings; | ||
|
|
||
| pub async fn spin_up_madara() -> MadaraCmd { | ||
| println!("Spinning up madara"); |
There was a problem hiding this comment.
there are some println! pending, can you check
ocdbytes
pushed a commit
that referenced
this pull request
Oct 16, 2024
* update dependencies * update imports * updated changelog * added testcase for bytes conversion * fix clippy error * use zaun for starknet * add simple test for settlement * add sepolia issue * to be fixed: validation error * add madara update state test * use relative path * add ci for settlement client * fix workflow debug * fix workflow debug * add scarb build * ignore flaky test * fix threads issue * add scarb build for madara * check if tool version present * fix workflow debug * fix workflwo * fix directory * should fix it * fix bash command * fix bash command * make scarb installation separate step * use swm action * fix ci path * lint fixed * fix env path for tests * fix lint * remove extra path * try checking structure * check * fix env path * fix the directory * try go into * fix path * remove working directory * final fix * fix: gets triggered multiple times * fix path * fix prettier * change calldata type to (#133) * update workflow * fix lints * Update crates/settlement-clients/starknet/src/tests/test.rs Co-authored-by: Apoorv Sadana <95699312+apoorvsadana@users.noreply.github.com> * resolve comments * fix e2e test flow * fix toml lint * Update crates/settlement-clients/starknet/src/tests/test.rs Co-authored-by: Apoorv Sadana <95699312+apoorvsadana@users.noreply.github.com> * changed envs * add conversion function and test * remove redundant test * update workflow commit hash * change commit and add prettierignore * nonce implementaion and optimise code * remove coverage bin env * changed to logs * added preset file * update versioned constants path * fix current_path * should do inplace replacement * fix base path * fix final coverage workflow * update preset * change runner * install dependencies * run linter * remove path * reword * change default rust * rerun * install libclang * install more dependencies * install yq * install via snap * install snap first * add y flag * no y flag * enable snapd service * use gh action for yq * yq action * remove working-directory * check env variable * fix ci * remove override in e2e * dotenvy::from_filename * should also build * env override * ignore flaky test * restart ci * enable cargo build * override in starknet client * only starknet * retry running * test settle should work * remove fail fast * update blocktime * change commit * run all tests * resolve comments * added test for get nonce * remove log --------- Co-authored-by: Apoorv Sadana <95699312+apoorvsadana@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.