Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove all unwraps #153

Merged
merged 13 commits into from
Oct 11, 2024
Merged

remove all unwraps #153

merged 13 commits into from
Oct 11, 2024

Conversation

byteZorvin
Copy link
Member

  • This pr fixes clean unwraps #118
  • Removes all unwraps() except for in test cases or while setup functions where they can be changed to expect()

@coveralls
Copy link

coveralls commented Oct 10, 2024 •
edited
Loading

Coverage Status

coverage: 64.32% (-0.1%) from 64.415%
when pulling 5ea2815 on remove-unwraps
into 1c090fb on main.

Mohiiit
Mohiiit reviewed Oct 10, 2024
View reviewed changes
Copy link
Contributor

@Mohiiit Mohiiit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the nitpick

crates/orchestrator/src/jobs/da_job/mod.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/jobs/mod.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/jobs/state_update_job/utils.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/main.rs Outdated Show resolved Hide resolved
crates/prover-services/sharp-service/src/client.rs Outdated Show resolved Hide resolved
crates/settlement-clients/starknet/src/tests/setup.rs Outdated Show resolved Hide resolved
byteZorvin and others added 3 commits October 11, 2024 01:39
@byteZorvin byteZorvin mentioned this pull request Oct 11, 2024
Open
apoorvsadana
apoorvsadana reviewed Oct 11, 2024
View reviewed changes
crates/orchestrator/src/jobs/mod.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/jobs/mod.rs Outdated Show resolved Hide resolved
@apoorvsadana apoorvsadana merged commit f5d986d into main Oct 11, 2024
9 checks passed
ocdbytes pushed a commit that referenced this pull request Oct 16, 2024
@byteZorvin @heemankv @Mohiiit
remove all unwraps (#153)
3b04d66 
* remove all unwraps

* update changelog

* fix toml lint

* Apply suggestions from code review

Co-authored-by: Mohit Dhattarwal <48082542+Mohiiit@users.noreply.github.com>

* made error consistent

* resolve comments

* fix small comment

* move to conversion.rs

* fix: borrow issue

* fix: clippy warning

---------

Co-authored-by: Heemank Verma <heemankv@gmail.com>
Co-authored-by: Mohit Dhattarwal <48082542+Mohiiit@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoorvsadana apoorvsadana apoorvsadana approved these changes

@Mohiiit Mohiiit Mohiiit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clean unwraps
5 participants
@byteZorvin @coveralls @Mohiiit @apoorvsadana @heemankv