Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expect removed from various places #197

Merged
merged 5 commits into from
Jan 7, 2025
Merged

Expect removed from various places #197

merged 5 commits into from
Jan 7, 2025

Conversation

Mohiiit
Copy link
Contributor

@Mohiiit Mohiiit commented Dec 24, 2024

Removed expect and added wrap for the error

@coveralls
Copy link

coveralls commented Dec 24, 2024

Coverage Status

coverage: 67.496% (+0.06%) from 67.433%
when pulling 0fe17f8 on fix/s3-error
into 15b321b on main.

@Mohiiit Mohiiit self-assigned this Dec 26, 2024
@Mohiiit Mohiiit requested a review from ocdbytes December 26, 2024 10:23
Copy link
Member

@ocdbytes ocdbytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!

Copy link
Contributor

@heemankv heemankv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mohiiit Mohiiit merged commit cb8d82f into main Jan 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants