Feat : alerts module #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ocdbytes
commented
Aug 22, 2024
ocdbytes
commented
- Added alerts module.
- Added SNS implementation.
- Updated tests.
… into feat/alerts-module
Comment on lines
+15
to
+16
| let config = aws_config::from_env().region(Region::new(sns_region)).load().await; | ||
| AWSSNS { client: Client::new(&config) } |
There was a problem hiding this comment.
I was comparing this to the S3 config and I noticed a few things
- We can use the same config built here in S3 as well (we will need to change
Client::from_confto Client::new inside s3) - We should probably move AWS config creation into config.rs and pass it to s3 and sns
- s3
newdoesn't need to async (and even SNS once can be made non sync after that) - S3 config only needs to have bucket name after this
- SNS should also have a config that has topic arn which then gets loaded into the SNS struct (similar to S3)
There was a problem hiding this comment.
we can make a new issue for this idts this is related to this PR and will cause unnecessary confusion amongst the reviewers.
apoorvsadana
approved these changes
Aug 24, 2024
ocdbytes
added a commit
that referenced
this pull request
Oct 16, 2024
* feat : alerts module init * feat : added alerts in jobs/mod.rs * feat : updated messages * feat : updated tests with alerts module mock * changelog : update * feat : added additional alerts * feat : added test for alerts and added logs at queue level * refactor : removed redundant alerts * feat : updated workflow * feat : resolved comments * feat : added all alerts for queues * feat : updated code * remove queue url const * feat : tests and lint fixes --------- Co-authored-by: apoorvsadana <95699312+apoorvsadana@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.