-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PARC and HMML #84
Conversation
WalkthroughThe Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (1)
- src/lib/data/entries.json
Files selected for processing (1)
- README.md (2 hunks)
Additional comments: 3
README.md (3)
32-34: The entry for PARC is well-formatted and consistent with the other entries in the "Africa" section. The description is concise and informative.
90-90: The entry for HMML is correctly placed in the "Global" section and follows the established format for resource listings.
29-38: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [29-93]
Please ensure that
npm run awesome-lint
has been executed to verify that the formatting of the README.md file adheres to the project's standards.
@DominicWeber Thanks for your contribution. Please add a region (or an empty region array) to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (1)
- src/lib/data/entries.json
Files selected for processing (1)
- README.md (3 hunks)
Files skipped from review due to trivial changes (1)
- README.md
Done, although |
Pull Request
Add / Remove / Change
{entry name}
insrc/lib/data/entries.json
.PARC is a collection of primary sources for African History.
HMML is a collection of digitized manuscripts from all over the world.
Describe why this change is made. Alternatively, refer to existing issues if any. You could try to answer:
Checklist
Please ensure that you have completed the following tasks:
npm run prepare
to sort the entries insrc/lib/data/entries.json
alphabetically and to generate theREADME.md
file.npm run format
to format the repository code.npm run awesome-lint
to ensure that theREADME.md
file is formatted correctly.Criteria for accepting a pull request
Contributors, please ensure that:
Maintainers, please ensure that:
Updating your PR
If the maintainers notice anything that needs to be changed, they will ask you to edit your PR before merging it. Please do not open a new PR, just edit the existing one. If you're not sure how to do that, here is a guide on the different ways you can update your PR.
Appendix: running lint tests
To run tests locally using Node.js, you need to install the dependencies first:
Summary by CodeRabbit