handle templates with errors when extracting variables

mailcarrierapp · Mar 19, 2024 · f27ecef · f27ecef
1 parent 4332580
commit f27ecef
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 3 deletions.
diff --git a/src/Helpers/TemplateManager.php b/src/Helpers/TemplateManager.php
@@ -24,9 +24,14 @@ public function extractVariableNames(): array
         $source = $this->template->layout?->content . $this->template->content;
 
         $twig = new Environment(new ArrayLoader());
-        $nodes = $twig->parse(
-            $twig->tokenize(new Source($source, ''))
-        )->getNode('body')->getNode('0');
+
+        try {
+            $nodes = $twig->parse(
+                $twig->tokenize(new Source($source, ''))
+            )->getNode('body')->getNode('0');
+        } catch (\Exception) {
+            return [];
+        }
 
         preg_match_all("|Twig\\\Node\\\Expression\\\NameExpression\(name\: '(.*)'|mi", (string) $nodes, $matches);
 

diff --git a/tests/Unit/TemplateManager/ExtractVariableNamesTest.php b/tests/Unit/TemplateManager/ExtractVariableNamesTest.php
@@ -67,3 +67,17 @@
 
     expect($output)->toBe(['headline', 'name', 'ctaUrl', 'isPremium', 'tierLevel']);
 });
+
+it('returns empty array for a template with errors', function () {
+    $template = new Template([
+        'content' => <<<'TWIG'
+            Hello {{ name }},
+            {% if isPremium|default(false) %%}
+                {{ tierLevel|title }}
+        TWIG,
+    ]);
+
+    $output = TemplateManager::make($template)->extractVariableNames();
+
+    expect($output)->toBe([]);
+});