Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add command to retry failed sent emails #35

Conversation

lkeio
Copy link
Contributor

@lkeio lkeio commented Jun 4, 2024

Description

  • Created a command that allows retrying emails from the log, functioning as follows:
    • If no date is provided, it defaults to yesterday's date.
    • If a date is specified, it uses the logs for that day.
  • Moved the logic for sending emails from src/Resources/LogResource.php to a new action src/Actions/Logs/ResendEmail.php.
  • Utilized the new action inside src/Resources/LogResource.php to maintain backward compatibility.
  • Fixed a bug in LogFactory for the cc and bcc fields.

Type of change

  • Bug fix
  • New feature

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

How Has This Been Tested?

Created 2 tests to verify the new feature:

  • Resends emails from failed logs.
  • Resends emails from failed logs for a specific date.

@danilopolani danilopolani merged commit ceb99c3 into mailcarrierapp:master Jun 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants