create "persistent" test group #769
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkralik3
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates the test group
Persistentand marks according tests with this group. The group is intended to denote which tests do not tear down the resources used within the test (most importantly, those which do not recreate the mesh namespace in between subtests or during cleanup). Hence, the name "Persistent" as the namespace persists after the test cleanup.The goal here is to be able to run this subset of tests while also having a 3.0 mesh in the same namespace to test migration paths.
Note: see comment / change in
scripts/runtime.shwhere I changed a hardcoded namespace list. Need advice on if this is acceptable or if there is some easier way to make this configurable because in my first look it was not clear if there was an easy way to configure this option.