Skip to content

Commit

Permalink
MySQLTuner dont understand Thread Pool in Percona Server 5.7 #386
Browse files Browse the repository at this point in the history
  • Loading branch information
jmrenouard committed Sep 26, 2018
1 parent dab1e7e commit c8fb973
Showing 1 changed file with 2 additions and 14 deletions.
16 changes: 2 additions & 14 deletions mysqltuner.pl
Original file line number Diff line number Diff line change
Expand Up @@ -3070,27 +3070,15 @@ sub mysql_stats {
}

# Thread cache
# if ( $myvar{'thread_cache_size'} eq 0 ) {
# badprint "Thread cache is disabled";
# push( @generalrec, "Set thread_cache_size to 4 as a starting value" );
# push( @adjvars, "thread_cache_size (start at 4)" );
# }
# else {
# if ( defined( $myvar{'thread_handling'} )
# and $myvar{'thread_handling'} eq 'pools-of-threads' )
# {
# infoprint "Thread cache hit rate: not used with pool-of-threads";
# }

if ( defined( $myvar{'thread_handling'} )
and $myvar{'thread_handling'} eq 'pool-of-threads' )
{
# https://www.percona.com/doc/percona-server/LATEST/performance/threadpool.html
# When thread pool is enabled, the value of the thread_cache_size variable
# is ignored. The Threads_cached status variable contains 0 in this case.
infoprint "Thread cache not used with thread_handling=pool-of-threads";
}
else {
}
else {
if ( $myvar{'thread_cache_size'} eq 0 ) {
badprint "Thread cache is disabled";
push( @generalrec, "Set thread_cache_size to 4 as a starting value" );
Expand Down

0 comments on commit c8fb973

Please sign in to comment.