Fix issues for Rails 7.2 #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kratob
force-pushed
the
rails_7_2
branch
2 times, most recently
from
261d79b to
5580713
Compare
|
I seem to have fixed it, but the whole approach of the |
|
@FLeinzi maybe you can take a look. I cannot request a review since you own the PR. |
FLeinzi
commented
Aug 13, 2024
lib/active_type/no_table.rb
Outdated
Comment on lines
155
to
157
| def cached_find_by(*) | ||
| end |
There was a problem hiding this comment.
Shouldn't we explicitly return nil or [] (like in the methods above) here?
kratob
changed the title
|
This should fix #190. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.