Fix belongs_to
association validation for virtual attributes
#200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
belongs_to
associations inActiveType::Object
did not properly validate presence whenActiveRecord::Base.belongs_to_required_by_default = true
andActiveRecord.belongs_to_required_validates_foreign_key = false
(Rails default).This is because the
validates_presence_of
validation usesActiveType::Object#attribute_changed?
and it returns alwaysfalse
for virtual attributes.https://github.com/rails/rails/blob/v8.0.1/activerecord/lib/active_record/associations/builder/belongs_to.rb#L135
This commit implements
ActiveType::VirtualAttributes#attribute_changed?
and fixes the problem.The same applies to
ActiveType::Record
.