Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Runtime
(and related subclasses) to take an object with named things, rather than an arbitrary list of things:new Runtime({ urlReader, connections })
Malloy.compile
to allow you to pass in aurl: URL
orsource: string
directly, rather than having to first callMalloy.parse
. Therefore, you only need to useMalloy.parse
if you only want to parse. If you always want to compile, you may as well useMalloy.compile
.CacheManager
, which maintains the information needed to interact with aModelCache
which is an async map fromURL
to{modelDef: ModelDef; invalidationKeys: {[url: string]: InvalidationKey}}
, whereinvalidationKeys
should be the set of invalidation keys for all the files (including the root file itself) that the cached model depends on.URLReader
's interface to add knowledge of invalidation keys. It has been modified in such a way that if you don't change your url readers, they'll still work. If you aren't passing invalidation keys, we'll just hash the file contents for you.