[FEATURE] NPM package #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a side note, I think we can remove Backbone and JQuery as strict dependencies. Should shave off about 1.5MB from the package size. |
|
With release of v2, viking has moved to a full esm module, and is now installable via npm package. |
# By Ben Ehmke (6) and Jon Bracy (1) # Via GitHub * master: Association Order (#52) move load and loaded events on association to only fire when actual load (#51) Change View.$ to querySelector instead of querySelectorAll (#49) Application waits for itself to render before displaying a view (#48) Automatically add X-CSRF-TOKEN header if csrf-token available in the document (#46) add return for map, and forEach alias (#47) Viking V2 (#44) # Conflicts: # Gemfile.lock # package-lock.json # package.json # viking.js
|
Hmmm I do want some of the stuff here tho |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a prepack script to the
package.jsonthat compiles the viking.js output along with necessary dependencies so that we can publish the package to npm.