-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Containerless tools #74
Conversation
c122c97
to
72e91e6
Compare
72e91e6
to
0b9b967
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0b9b967
to
e4a228a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the following code can be simplified, since python3 already has builtin function any
for OR
ing all the elements in the iterable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this as well. Didn't see these occurences the first time.
e4a228a
to
2a9e026
Compare
2a9e026
to
bda5f6f
Compare
Applied the suggested code changes. |
Can we get this merged? Having a dmalog Qemu in bootstrap would be really nice, and as far as I can tell, all concerns here have been addressed. |
bda5f6f
to
79857eb
Compare
Co-authored-by: Fedor Lapshin <fe.lap.prog@gmail.com>
79857eb
to
1bc527f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This allows for building tools that don't compile and link against the container but against the host machine. This is useful for building a QEMU in bootstrap for instance:
This allows the result QEMU to use host libraries, resulting in more features of it being available and not having to ship dozens of host tools.