Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimize getDistance #311

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

perf: optimize getDistance #311

wants to merge 1 commit into from

Conversation

vicb
Copy link

@vicb vicb commented Oct 18, 2024

Calling toRad upfront reduces the number of calls from 6 to 3.

Perf test show that the updated version is a little over 1% faster. That's not much but still better.

Thanks for your great lib!

Calling toRad upfront reduces the number of calls from 6 to 3.
@vicb
Copy link
Author

vicb commented Oct 28, 2024

@manuelbieh any thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant