Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding mac keyboard bindings #271

Merged
merged 5 commits into from
Apr 9, 2018
Merged

Adding mac keyboard bindings #271

merged 5 commits into from
Apr 9, 2018

Conversation

ziveo
Copy link
Contributor

@ziveo ziveo commented Mar 16, 2018

This PR is adding missing mac keyboard bindings

@orangemug
Copy link
Collaborator

Hi @ziveo thanks for the pull request, much appreciated. How about using something like

const isMac = navigator.platform.toUpperCase().indexOf('MAC')>=0;
if(isMac) {
  // Mac bindings...
}
else {
  // Non mac bindings...
}

So we only bind for the environment we're interested in?

Ref: https://stackoverflow.com/questions/10527983/best-way-to-detect-mac-os-x-or-windows-computers-with-javascript-or-jquery

@orangemug
Copy link
Collaborator

Bojan Zivkovic and others added 2 commits March 16, 2018 23:00
@ziveo
Copy link
Contributor Author

ziveo commented Mar 17, 2018

I think this will work

@orangemug
Copy link
Collaborator

Thanks @ziveo merging

@orangemug orangemug merged commit 6d094a8 into maplibre:master Apr 9, 2018
@orangemug
Copy link
Collaborator

...also @ziveo if you have time please share what you're using Maputnik for over in ticket #164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants