Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass through SSSOM JSON-LD context when writing JSON #479

Merged
merged 9 commits into from
Dec 11, 2023
Merged

Pass through SSSOM JSON-LD context when writing JSON #479

merged 9 commits into from
Dec 11, 2023

Conversation

matentzn
Copy link
Collaborator

@matentzn matentzn commented Dec 11, 2023 •
edited by cthoyt
Loading

Fixes #477

@matentzn matentzn mentioned this pull request Dec 11, 2023
Closed
@cthoyt cthoyt changed the title Bring back the context description for JSON ld serialised files Pass through SSSOM JSON-LD context when writing JSON Dec 11, 2023
@matentzn
Rename _get_context to _update_sssom_context_with_prefixmap
8b06cef 
@cthoyt there was an issue here in that you overwrote the `@context` while we had to augment the existing one.
@matentzn
Adding two tests for to_json() contexts
d5be76e 
cc @cthoyt

The tests are "explicit", but not "comprehensive" (there is a lot of stuff that could be tested, but my guess is, if one thing works, everything works with 99% probablility)
@matentzn
Update test_writers.py
f30bfd3
cthoyt
cthoyt reviewed Dec 11, 2023
View reviewed changes
src/sssom/writers.py Outdated Show resolved Hide resolved
cthoyt
cthoyt reviewed Dec 11, 2023
View reviewed changes
src/sssom/writers.py Outdated Show resolved Hide resolved
@cthoyt
Make helper function more idiomatic
72b2920 
avoid serializing and deserializing over and over
@cthoyt
Update writers.py
3ba8993
@matentzn matentzn marked this pull request as ready for review December 11, 2023 14:52
@matentzn matentzn requested a review from hrshdhgd December 11, 2023 14:54
@hrshdhgd hrshdhgd merged commit f425604 into master Dec 11, 2023
6 checks passed
@hrshdhgd hrshdhgd deleted the fix-jsonld-context branch December 11, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cthoyt cthoyt cthoyt left review comments

@hrshdhgd hrshdhgd hrshdhgd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@context missing the type definitions in version 0.4.0
3 participants
@matentzn @cthoyt @hrshdhgd