Fix setEntry(title) for titles containing icons

Close #109
mar10 · Jan 27, 2017 · 761ceee · 761ceee
1 parent 12f318e
commit 761ceee
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,5 @@
-# 1.13.0-0 / Unreleased
- *
+# 1.13.1-0 / Unreleased
+ * [BUGFIX] #109 Fix `setEntry(title)` for titles containing icons
 
 # 1.13.0 / 2016-08-21
 

diff --git a/jquery.ui-contextmenu.js b/jquery.ui-contextmenu.js
@@ -476,13 +476,14 @@ $.extend($.moogle.contextmenu, {
 			return item.has(">div[aria-haspopup='true']").length > 0;
 		}
 	},
-	/** Replaces the value of elem's first text node child */
-	replaceFirstTextNodeChild: function(elem, text) {
+	/** Replace the title of elem', but retain icons andchild entries. */
+	replaceFirstTextNodeChild: function(elem, html) {
+		var $icons = elem.find(">span.ui-icon,>ul.ui-menu").detach();
+
 		elem
-			.contents()
-			.filter(function() { return this.nodeType === 3; })
-			.first()
-			.replaceWith(text);
+			.empty()
+			.html(html)
+			.append($icons);
 	},
 	/** Updates the menu item's title */
 	updateTitle: function(item, title) {