Fixes for Niai sorting by locked status then score #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…userscripts into niai-display-sorting
Due to the internal database not being up to date with Wanikani content movements, unlocked items would end up in the locked section. This address the issue by incorporating more use of open framework in updating items
New minor version due to scope of the changes made regarding further incorporation of Wanikani Open Framework
…styles that override them (mwil#27) * Update: Keisei: use wk css variables, other improvements * Update: add pointer style to anchors in dropdown menu * Keisei: update user.js * Fix: small style fixes * Keisei: update user.js * Fix: border of items in chargrid * Keisei: update user.js * Fix: careless copy-paste error * Keisei: update user.js * Fix: accidental deletion of css rule * Keisei: update user.js
…nd (mwil#28) * Update: Niai: style improvements * Update: shared styles improvements * Fix: issue where sim_kanji was not variable logged * Fix: Niai: a few oversights * setting user level * duplication of bootstrap injection * conflicting default min_score * Niai: update user.js * Fix: small style fixes * Niai: update user.js * Fix: curPage has no default All but one instance of `populateNiaiSection` call it with nothing passed as the second argument, so a default should be set. Fixed condition checking against "itemInfo" which is not a possible value for the `on` field. Fixed one instance where an empty string was explicitly passed as the argument for `curPage`. * Fix: border of items in chargrid * Niai: update user.js * Fix: careless mistakes * forgot to use `this` on subsequent `wkItemInfo` references * copy-paste error in chargrid * Niai: update user.js * Fix: accidental deletion of css rule * Niai: update user.js * Feature: update reading via wkof * Niai: update user.js * Fix: script does not check for update to user level * Niai: update user.js
* Add try-catch for testing * Update wk_keisei.user.js * test passing Icons as argument * Update wk_keisei.user.js * Niai and Keisei: try to fix initialization of Icons * Niai and Keisei: Update user.js * Niai and Keisei: update user.js versions
…ts into niai-display-sorting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I detailed the issues present in mwil#23. I was able to figure out less drastic changes than I was initially thinking, so I decided I would make this pull request. It seems this fork is fairly out of date with upstream so merging this PR will also bring in the latest changes from upstream.