Checking in my changes. #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes fixes to the synthetic document generation process.
It consistently generates figure content (logos, barcodes, QR codes) and uses appropriately sized assets for the backgrounds for paragraph and list content.
I extracted some of the utility functions into utility modules.
a. I also extracted some of the static factory methods into static factory classes in their own files.
I also added a lot of logging which can be removed when we are done with the solution.
a. The default log level is INFO but I've provided a simple interface for configuring to show DEBUG and up if necessary.
This also updates the README with useful information on getting started with the project.