Skip to content

Commit

Permalink
fix: bump narwhals to 1.12.0 (#2742)
Browse files Browse the repository at this point in the history
  • Loading branch information
mscolnick authored Oct 29, 2024
1 parent a2b8866 commit 1776191
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ dependencies = [
# required dependency in Starlette for SessionMiddleware support
"itsdangerous>=2.0.0",
# for dataframe support
"narwhals>=1.9.0",
"narwhals>=1.12.0",
# for cell formatting; if user version is not compatible, no-op
# so no lower bound needed
"ruff",
Expand Down Expand Up @@ -147,7 +147,7 @@ dependencies = [
# Types for mypy
"panel~=1.5.3",
"polars~=1.9.0",
"narwhals>=1.9.0",
"narwhals>=1.12.0",
"matplotlib>=3.8.0",
"pyarrow-stubs>=17.0",
"pandas-stubs>=1.5.3.230321",
Expand Down
2 changes: 1 addition & 1 deletion tests/_plugins/ui/_impl/tables/test_pandas_table.py
Original file line number Diff line number Diff line change
Expand Up @@ -738,7 +738,7 @@ def test_dataframe_with_all_null_column(self) -> None:
summary = manager.get_summary("B")
assert summary.nulls == 3
assert summary.total == 3
assert summary.unique == 1
assert summary.unique is None

def test_dataframe_with_mixed_types(self) -> None:
df = pd.DataFrame({"A": [1, "two", 3.0, True]})
Expand Down

0 comments on commit 1776191

Please sign in to comment.