fix: scroll when adding new cell at the bottom (#1782)

marimo-team · Jul 11, 2024 · f936c92 · f936c92
1 parent b0efec0
commit f936c92
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/frontend/src/core/cells/cells.ts b/frontend/src/core/cells/cells.ts
@@ -663,7 +663,6 @@ const {
     if (index === state.cellIds.length - 1) {
       const cellId = state.cellIds[state.cellIds.length - 1];
       state.cellHandles[cellId].current?.editorView.focus();
-      scrollToBottom();
     } else {
       const nextCellId = state.cellIds[index];
       focusAndScrollCellIntoView({

diff --git a/frontend/src/core/cells/scrollCellIntoView.ts b/frontend/src/core/cells/scrollCellIntoView.ts
@@ -94,7 +94,7 @@ export function focusAndScrollCellOutputIntoView(cellId: CellId) {
  */
 export function scrollToBottom() {
   const app = document.getElementById("App");
-  app?.scrollTo({ top: document.body.scrollHeight, behavior: "smooth" });
+  app?.scrollTo({ top: app.scrollHeight, behavior: "smooth" });
 }
 
 export function scrollToTop() {