-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: marimo islands (Windows-related) + doc touchups #3242
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Haleshot is attempting to deploy a commit to the marimo Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a round of comments
…e outdated usage examples
Any reason (cost, etc.) for mkdocs-vercel deploy to require authorization now? Don't think this was there before the migration from furo-sphinx to mkdocs. Just that, I rely on the deployment to see how the docs pans out (especially when using mkdocs-specific syntax and features - tabs, etc) as developing on windows, the make docs (contributing guide for docs) causes issues in creating docs locally. |
docs/guides/exporting.md
Outdated
!!! example | ||
|
||
/// tab | Using uv run | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's delete this section on uv run
Removed the uv run block (though I thought it would be good to show instructions on using the uv run command for islands). Also, I hope I resolved the admonition (it seemed to be an indent issue). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks again for the Windows fix :)
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.10.10-dev8 |
📝 Summary
Will be improving docs for islands soon (if that's alright); I believe islands based implementations (conversions, etc) can be elaborated on. Fix windows-based issues too.
🔍 Description of Changes
pnpm dev:islands
anduv run .py > .html
| Windows #3239cross-env
package for loading vite server.📋 Checklist
📜 Reviewers
@akshayka OR @mscolnick