Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add unit tests for codemirror modules #3275

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Add unit tests for codemirror modules

Added Vitest unit tests for the following modules:

  • editing/commands.ts: Tests for bulk command functionality and fold/unfold operations
  • placeholder/extensions.ts: Tests for smart placeholder and clickable placeholder extensions
  • theme/light.ts: Tests for theme configuration and syntax highlighting styles

Test Coverage

  • All tests follow Vitest patterns using describe, it, and expect
  • Tests focus on pure functions without jotai/state dependencies
  • Comprehensive coverage of core functionality
  • All tests passing locally

Testing

  • ✓ Verified with pnpm test
  • ✓ All tests passing
  • ✓ No regressions in existing tests

Link to Devin run: https://app.devin.ai/sessions/da6b7807b96846f490913db227d1b665

Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Add "(aside)" to your comment to have me ignore it.

Copy link

vercel bot commented Dec 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 5:01pm
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 5:01pm

@mscolnick mscolnick force-pushed the devin/1734809178-codemirror-theme-tests branch from 62bd296 to 97ab4f6 Compare December 23, 2024 16:41
mscolnick
mscolnick previously approved these changes Dec 23, 2024
@mscolnick mscolnick merged commit d173c21 into main Dec 23, 2024
22 checks passed
@mscolnick mscolnick deleted the devin/1734809178-codemirror-theme-tests branch December 23, 2024 17:05
Copy link

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.10.7-dev29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant