Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: number input reset #3276

Merged
merged 4 commits into from
Dec 23, 2024
Merged

fix: number input reset #3276

merged 4 commits into from
Dec 23, 2024

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Fix NumberPlugin so it resets the displayed value. Closes #3264

Link to Devin run: https://app.devin.ai/sessions/fd67afc6d6bb4ff7b6f949d64c0ed034

Changes:

  • Fixed useDebounceControlledState hook to handle reset behavior correctly
  • Added test coverage for NumberPlugin reset functionality
  • Added aria-label to NumberField for improved accessibility

Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Add "(aside)" to your comment to have me ignore it.

Copy link

vercel bot commented Dec 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 4:58pm
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 4:58pm

mscolnick
mscolnick previously approved these changes Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number inputs don't correctly reset with button use
1 participant