Add mhchem #3311
Merged
Add mhchem #3311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
All contributors have signed the CLA ✍️ ✅ |
|
@LioSergent, thanks for the PR! Can you sign the CLA by adding a comment with the following line? I have read the CLA Document and I hereby sign the CLA |
|
I have read the CLA Document and I hereby sign the CLA |
mscolnick
reviewed
Dec 30, 2024
LioSergent
force-pushed
the
add-mhchem
branch
from
004be65 to
b66cd4c
Compare
akshayka
approved these changes
Jan 2, 2025
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.10.10-dev4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
I would like to be able to write chemical equations conveniently in marimo.
This pull request is an attempt at including katex' mhchem extension, which allows for convenient chemical writing through \ce command, but also clean physical unit typesetting with the \pu command (somewhat similar to siunitx in latex).
Related to https://discordapp.com/channels/1059888774789730424/1318274202507284531
Note : this is the first time I'm trying to contribute to an open-source project, and I honestly don't really know what I am doing, but since the change is very small, I thought I could try. I just tried to make https://katex.org/docs/node#using-mhchem-extension work.
🔍 Description of Changes
📋 Checklist
I have not tested for performance. Not sure how to test for that. In case it bloats the app, maybe it should be set as an option, or marimo could detect if \ce or \pu is written somewhere.
Note: for comparison, Jupyter uses Mathjax which also allows for mhchem functionality through an extension. The extension isn't loaded by default (although it's very easy to load, either in a cell via "$$\require{mhchem}$$" or through the user's ipython config).
However, another example, obsidian.md (the note-taking app I use) also uses Mathjax, and does load mhchem by default.
Not sure why KaTeX chose to put mhchem commands \ce and \pu as an extension. mhchem feels like just a convenient (and thin) wrapper around things like \mathrm.
📜 Reviewers
@mscolnick